RS/CH/get_zcc #269
Merged
RS/CH/get_zcc #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingcx
reviewed
Mar 1, 2022
| @@ -64,7 +66,7 @@ Logic: | |||
| - For each surface in zone: `for surface in zone.surfaces:` | |||
|
|
|||
| - Check if surface is interior, get adjacent zone: `if surface.adjacent_to == "INTERIOR": adjacent_zone = match_data_element(RMR, zones, surface.adjacent_zone_id)` | |||
|
|
|||
| **[CH: There is no `surface.fenestration_subsurfaces` field. There is a `surface.subsurfaces` field instead. Subsurface has `opaque_area` and `glazed_area`.]** | |||
There was a problem hiding this comment.
Surface.fenestration_subsurfaces is no longer in the schema. I'll correct the calculation below.
| @@ -88,7 +90,7 @@ Logic: | |||
| - For each space in zone: `for space in zone.spaces:` | |||
|
|
|||
| - Check if lighting space type is residential, space is classified as residential: `if space.lighting_space_type in ["DORMITORY_LIVING_QUARTERS" , "FIRE_STATION_SLEEPING_QUARTERS", "GUEST_ROOM", "DWELLING_UNIT", "HEALTHCARE_FACILITY_NURSERY", "HEALTHCARE_FACILITY_PATIENT_ROOM"]: space_residential_flag = TRUE` | |||
|
|
|||
| **[CH: I suggest replacing `space_residential_flag` with `zone_has_residential_spaces` and replacing `space_nonresidential_flag` with `zone_has_residential_spaces`.]** | |||
| @@ -107,10 +109,10 @@ Logic: | |||
|
|
|||
| - Else if zone has interior parking spaces, classify zone as unenclosed: `if（ space.lighting_space_type == "PARKING_AREA_INTERIOR" for space in zone.spaces ）: zone_conditioning_category_dict[zone.id] = "UNENCLOSED"` | |||
|
|
|||
| - Else if zone is crawlspace, classify zone as unenclosed: `else if ( ( zone.volume / sum( space.floor_area for space in zone.spaces ) ) < CRAWLSPACE_HEIGHT_THRESHOLD ) AND ( ( get_opaque_surface_type(surface) in ["HEATED SLAB-ON-GRADE", "UNHEATED SLAB-ON-GRADE"] ) AND ( surface.adjacent_to == "GROUND" ) for surface in zone.surfaces ): zone_conditioning_category_dict[zone.id] = "UNENCLOSED"` (Note XC, need to check surface != Floor, RDS online not updated) | |||
| - Else if zone is crawlspace, classify zone as unenclosed: `else if ( ( zone.volume / sum( space.floor_area for space in zone.spaces ) ) < CRAWLSPACE_HEIGHT_THRESHOLD ) AND ( ( get_opaque_surface_type(surface) in ["HEATED SLAB-ON-GRADE", "UNHEATED SLAB-ON-GRADE"] ) AND ( surface.adjacent_to == "GROUND" ) for `**[CH: insert `any`]**` surface in zone.surfaces ): zone_conditioning_category_dict[zone.id] = "UNENCLOSED"` (Note XC, need to check surface != Floor, RDS online not updated) | |||
There was a problem hiding this comment.
This is corrected. Also deleted the surface.adjacent_to requirement. Heated and unheated slab-on-grades are adjacent to ground by definition.
|
|
||
| - Else if zone is attic, classify zone as unenclosed: `else if ( ( get_opaque_surface_type(surface) == "CEILING" ) AND ( surface.adjacent_to == "EXTERIOR" ) for surface in zone.surfaces ): zone_conditioning_category_dict[zone.id] = "UNENCLOSED"` | ||
| - Else if zone is attic, classify zone as unenclosed: `else if ( ( get_opaque_surface_type(surface) == "CEILING"`**[CH: ROOF?]**` ) AND ( surface.adjacent_to == "EXTERIOR" ) for `**[CH: insert `any`]**` surface in zone.surfaces ): zone_conditioning_category_dict[zone.id] = "UNENCLOSED"` |
There was a problem hiding this comment.
I'll correct "Ceiling" to "Roof“ and add any for surfaces.
|
|
||
| - Calculate and save total central heating output per floor area for HVAC system to dictionary: `hvac_heat_capacity_dict[hvac_sys_id] = total_central_heat_capacity / hvac_zone_list_w_area_dict[hvac_sys_id]["TOTAL_AREA"]` | ||
| - Get heated space criteria: `system_min_heating_output = data_lookup(table_3_2,climate_zone)` | ||
|
|
||
| - For each zone in RMR: `for zone in RMR...zones:` | ||
|
|
There was a problem hiding this comment.
I will need to include zonal cooling output in the calculation below. The schema has been updated to reflect that.
Add terminal.cooling_capacity; change fenestration to subsurface; change res/nonres flag name; update crawlspace qualification; correct unenclosed zone qualification;
weilixu
reviewed
Mar 7, 2022
| ] | ||
| for subsurface in find_all("subsurfaces[*]", surface) | ||
| ], | ||
| ZERO.U_FACTOR, | ||
| ) | ||
|
|
There was a problem hiding this comment.
See comment above about the F-factor & C-factor.
It seems the product of net surface area * surface U-value is not added?
update mock to actual zone conditioning category, Remove the test for 5-8
|
Will merge the ZCC an additional ticket is created to address the ground surfaces in the product sum of heat transfer rate. #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.