Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 22-7 and 22-33 Applicability #1454

Open
JacksonJ-KC opened this issue Aug 1, 2024 · 2 comments
Open

Rule 22-7 and 22-33 Applicability #1454

JacksonJ-KC opened this issue Aug 1, 2024 · 2 comments
Assignees
Labels
invalid This doesn't seem right section22

Comments

@JacksonJ-KC
Copy link
Collaborator

JacksonJ-KC commented Aug 1, 2024

When there is a primary loop and no secondary loop I would expect a FAIL outcome, however we are including 'at least one primary/secondary loop' as an applicability check for the rule.

The test cases that has modeled only a primary loop receives NOT_APPLICABLE instead of FAIL.

See get_primary_secondary_loops_dict()

@claperle
Copy link
Collaborator

claperle commented Aug 6, 2024

@JacksonJ-KC I don't understand the reason for the applicability check. I think it can be removed and would solve the issue you noticed. Do you agree?

@JacksonJ-KC
Copy link
Collaborator Author

Agreed

@JacksonJ-KC JacksonJ-KC changed the title Rule 22-33 Applicability Rule 22-7 and 22-33 Applicability Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right section22
Projects
None yet
Development

No branches or pull requests

5 participants