Update Rule23-1.md #1434
Update Rule23-1.md #1434
Conversation
KarenWGard
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
JacksonJ-KC
|
I think rule assertion cases can be reduced to this:
|
|
If a model has more than one thing incorrect, can we structure this in a way that provides all the feedback they need to get it fixed in a single run of the RCT? |
|
I'm not super familiar with calc_vals, but I could create some variables instead of hard-coding numbers into the rule assertion, then the user could look at this in the detailed RCT report:
|
docs/section23/Rule23-1.md
Outdated
| @@ -36,15 +36,15 @@ | |||
| - get the hvac system from the hvac_system_id: `hvac_system = get_component_by_id(hvac_system_id)` | |||
| - get the heating system: `heating_system = hvac_system.heating_system` | |||
| - get the heatpump_low_shutoff_temperature = `heatpump_low_shutoff = heating_system.heatpump_low_shutoff_temperature` | |||
| - get the auxiliary heat high temperature shutoff = 'aux_heat_high_temp_shutoff = heating_system.heatpump_auxilliary_heat_high_shutoff_temperature` | |||
There was a problem hiding this comment.
I think the last character needs to be corrected. Looks like a character is off making it so the python is not blue
docs/section23/Rule23-1.md
Outdated
| @@ -36,15 +36,15 @@ | |||
| - get the hvac system from the hvac_system_id: `hvac_system = get_component_by_id(hvac_system_id)` | |||
| - get the heating system: `heating_system = hvac_system.heating_system` | |||
| - get the heatpump_low_shutoff_temperature = `heatpump_low_shutoff = heating_system.heatpump_low_shutoff_temperature` | |||
| - get the auxiliary heat high temperature shutoff = 'aux_heat_high_temp_shutoff = heating_system.heatpump_auxilliary_heat_high_shutoff_temperature` | |||
| - get the auxiliary heat energy source: `aux_heat_energy_source = heatpump_auxilliary_heat_type` | |||
There was a problem hiding this comment.
I think this needs to be modified to aux_heat_energy_source = heating_system.heatpump_auxilliary_heat_type
docs/section23/Rule23-1.md
Outdated
| - Case 5: anything else, FAIL: `ELSE: Fail` | ||
| - Case 1: The auxiliary heat high temperature shutoff is greater than 40F, or the auxiliary heat energy source is anything other than electricity - FAIL: `if (aux_heat_high_temp_shutoff > 40) or (aux_heat_energy_source != "ELECTRIC_RESISTANCE"): FAIL` | ||
| - Case 2: The system type is 2 and the heatpump_low_shutoff is <= 17F OR tye system type is 4 and the heatpump_low_shutoff is <=10F, PASS: `if(system_type == HVAC_SYS.2 and heatpump_low_shutoff <= 17) or (system_type == HVAC_SYS.4 and heatpump_low_shutoff <= 10): PASS` | ||
| - Case 3: The system type is 2 and the heatpump_low_shutoff is >25F, FAIL, provide a message: `elif system_type == HVAC_SYS.2 && heatpump_low_shutoff > 25:` |
There was a problem hiding this comment.
Use of Ruby instead of python with the &&?
| - Case 4: the system type is 4 (we already know it's 4, because we've checked the 3 SYS 2 cases above), and the low shutoff temperature is <=10F: PASS: `if heatpump_low_shutoff <= 10F: PASS` | ||
| - Case 5: anything else, FAIL: `ELSE: Fail` | ||
| - Case 1: The auxiliary heat high temperature shutoff is greater than 40F, or the auxiliary heat energy source is anything other than electricity - FAIL: `if (aux_heat_high_temp_shutoff > 40) or (aux_heat_energy_source != "ELECTRIC_RESISTANCE"): FAIL` | ||
| - Case 2: The system type is 2 and the heatpump_low_shutoff is <= 17F OR tye system type is 4 and the heatpump_low_shutoff is <=10F, PASS: `if(system_type == HVAC_SYS.2 and heatpump_low_shutoff <= 17) or (system_type == HVAC_SYS.4 and heatpump_low_shutoff <= 10): PASS` |
There was a problem hiding this comment.
There is no Appendix G basis for this, correct? Based on recent discussions within the commitee, I am not sure we should be making these assumptions; I know we decided on this approach previously but wonder if it is still appropriate. It does seem like a no brainer to use 17F but not sure about the 10F since there were comments about us "interpreting" 90.1 requirements which this kind of falls into.
There was a problem hiding this comment.
I think that these minimum numbers come from the minimum temperature at which the heat pumps are rated based on the AHRI conditions from Table 6.8.1-2
There was a problem hiding this comment.
... but open to discussion.
There was a problem hiding this comment.
I don't think 10F is in those tables. 17F is though.
| - Case 1: The auxiliary heat high temperature shutoff is greater than 40F, or the auxiliary heat energy source is anything other than electricity - FAIL: `if (aux_heat_high_temp_shutoff > 40) or (aux_heat_energy_source != "ELECTRIC_RESISTANCE"): FAIL` | ||
| - Case 2: The system type is 2 and the heatpump_low_shutoff is <= 17F OR tye system type is 4 and the heatpump_low_shutoff is <=10F, PASS: `if(system_type == HVAC_SYS.2 and heatpump_low_shutoff <= 17) or (system_type == HVAC_SYS.4 and heatpump_low_shutoff <= 10): PASS` | ||
| - Case 3: The system type is 2 and the heatpump_low_shutoff is >25F, FAIL, provide a message: `elif system_type == HVAC_SYS.2 and heatpump_low_shutoff > 25:` | ||
| - `FAIL; note = "Fail because low temperature heat pump shutoff is above 25F for system 2. The modeled low temperature heat pump shutoff value is " + heatpump_low_shutoff + "."` |
There was a problem hiding this comment.
Same question of the 25F heat pump low shut off for System 2. Is this an interpretation from our side or is there a requirement that states this that I'm missing?
updates to address issue 1429