-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
245 gas workflows template updates #246
Merged
+34
−44
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a59051a
245 : Fixed text on High Efficiency Gas Furnace Manometer section.
lindsayJohnstonPnnl 13210d5
245 : Remove Manometer photo prompt from HE Water Heater template.
lindsayJohnstonPnnl 9b8757a
245 : Removed manometer photo prompt from HE Modulating boiler templa…
lindsayJohnstonPnnl 25504f2
245 : Removed manometer sections from the Report tabs in both HE Wate…
lindsayJohnstonPnnl 3f7dd75
245 : Edited text for Manometer for HE Gas Furnace.
lindsayJohnstonPnnl 40b24c1
245 : Change monometer to manometer.
lindsayJohnstonPnnl acef7ee
Merge remote-tracking branch 'origin/main' into 245-gas-workflows-tem…
lindsayJohnstonPnnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was an existing issue. There is a minor difference in the ID for this Photo component compared to PhotoInput: 'outlet_gas_pressure_monometer_photo'. Replace the 'o' with 'a' in 'manometer' to get 'outlet_gas_pressure_manometer_photo'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed "monometer" to "manometer" in both the id and the label.