Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

245 gas workflows template updates #246

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

lindsayJohnstonPnnl
Copy link
Collaborator

Before:

High Efficiency Gas Furnace
image

High Efficiency Water Heater
image

High Efficiency Modulating Boiler
image

After:

High Efficiency Gas Furnace
image

High Efficiency Water Heater
image

High Efficiency Modulating Boiler
image

@lindsayJohnstonPnnl lindsayJohnstonPnnl linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@sudhacheran sudhacheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested

@@ -134,8 +135,8 @@
Photo of the electronic methane leak detector while it is testing a gas connection
</Photo>

<Photo id="inlet_gas_pressure_monometer_photo" label="Monometer Showing Inlet Gas pressure – Photo" required>
Photo of the manometer measuring the inlet gas pressure
<Photo id="outlet_gas_pressure_monometer_photo" label="Monometer Showing Outlet Gas pressure – Photo" required>
Copy link
Collaborator

@sudhacheran sudhacheran Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an existing issue. There is a minor difference in the ID for this Photo component compared to PhotoInput: 'outlet_gas_pressure_monometer_photo'. Replace the 'o' with 'a' in 'manometer' to get 'outlet_gas_pressure_manometer_photo'.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed "monometer" to "manometer" in both the id and the label.

@sudhacheran sudhacheran self-requested a review December 10, 2024 22:15
@sudhacheran sudhacheran merged commit a44a833 into main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas workflows template updates
2 participants