-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R3F v9 in peerDependencies #2253
Comments
should we add |
i've checked and unintuitively: semver.satisfies('9.0.0-rc.1', '>=8.0') // false as well as semver.satisfies('9.0.0-rc.1', '^8 || ^9') // false we can either specifically add @verekia what do you think? |
Any Update? |
Currently, i think |
We can use semver.satisfies('9.0.0-rc.1', '^8 || ^9.0.0-0') // true
semver.satisfies('9.1.1', '^8 || ^9.0.0-0') // true
semver.satisfies('9.2.3-rc.4', '^9.0.0-0') // false I'll make a PR :) |
🎉 This issue has been resolved in version 9.120.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ah, we're going to need to update the react peerDep as well, since Drei requires 18 and R3F9 requires 19: https://github.com/pmndrs/drei/blob/master/package.json#L135 |
but as of now, i don't think drei is yet compatible with React 19, is it? |
But since R3F 9 is not compatible with React 18, we're a bit stuck here. |
let's wait otherwise, i don't think there is a special rush on going react 19 until r3f v9 is here, don't you think? |
but maybe drei is compatible with react 19, i haven't tested... |
I am using Drei in my React 19, R3F9 game. So far the components I am using work, except MultiMaterial. I think we can expect issues with a lot of them, so maybe this deserves to be a major bump + alpha version. It would be clearer that this new version of Drei is supposed to go with React 19, R3F9, and that there will be issues during this transition phase. |
Installing R3F v9 with Drei gives the following error due to the @react-three/fiber@">=8.0 peerDependency:
With the following dependencies:
In the meantime,
npm i --legacy-peer-deps
works.The text was updated successfully, but these errors were encountered: