Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace base mixins by PorePyModel as base class in porepy-provided simulation set-ups #1260

Open
vlipovac opened this issue Nov 5, 2024 · 0 comments
Assignees
Labels
implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group.

Comments

@vlipovac
Copy link
Contributor

vlipovac commented Nov 5, 2024

There are classes inside porepy which provide concrete set-ups for boundary conditions and md-grids for example.

As of now, some of them inherit directly from the respective mixins, which they should not in order to avoid MRO issues in the mixin framework.

Primarily affected are

  • porepy/applications
  • porepy/examples

A check whether other files/classes are affected should be carried out as well.

Fix:
Replace the mixins by the recently introduced PorePyModel protocol class, which suffices to provide an interface to the methods required from the mixins.
Make sure that no untyped code or code which cannot be picked up by linters, results from above changes.

@vlipovac vlipovac added implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group. labels Nov 5, 2024
@vlipovac vlipovac self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group.
Projects
None yet
Development

No branches or pull requests

1 participant