Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit signature of model methods representing terms in PDEs #1259

Open
vlipovac opened this issue Nov 5, 2024 · 0 comments
Open

Revisit signature of model methods representing terms in PDEs #1259

vlipovac opened this issue Nov 5, 2024 · 0 comments
Labels
implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group.

Comments

@vlipovac
Copy link
Contributor

vlipovac commented Nov 5, 2024

There are inconsistencies in the signature of respective methods, mostly regarding the usage of list[pp.Grid], pp.SubdomainOrBoundaries etc.

See this comment for example.

Fix:

  1. Go through models/*.py and check the signature of methods representing terms in some PDE or other equation.
  2. If the term appears possibly on the boundary, extend to pp.SubdomainOrBoundaries for example.

The challenge lies within the nested nature of functions. F.e. a density function might call 2-3 functions internally, which also require the same signature, but overall it should be a quick fix.

@vlipovac vlipovac added implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group. labels Nov 5, 2024
@vlipovac vlipovac changed the title Revisit signature of model methods representing terms in PDE Revisit signature of model methods representing terms in PDEs Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation - short An issue that requires a short implementation effort. user group Issue to be worked on in the internal user group.
Projects
None yet
Development

No branches or pull requests

1 participant