Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved implementation of TangentialNormalProjection #1224

Open
keileg opened this issue Sep 9, 2024 · 0 comments
Open

Improved implementation of TangentialNormalProjection #1224

keileg opened this issue Sep 9, 2024 · 0 comments

Comments

@keileg
Copy link
Contributor

keileg commented Sep 9, 2024

Projections between global coordinates and the local tangential-normal coordinate system of each fracture is currently handled by the class TangentialNormalProjection. The projection operation is implemented as a sparse matrix which to a large degree is constructed on the fly.

Two ideas for improvement:

  1. When Reimplementation of Ad projection operators #1182 is implemented, it should be possible to use this also for the projections (note: this will cover the projection to tangential and normal direction, but not the full projection, as the former are slices, while the latter is a weighted sum of rows). This may require a rewrite of the class to being an Ad operator. This could in itself be a good thing, as it will enable us to do parsing etc.
  2. More speculatively, it could be possible to use existing implementations of rotation operations (think Givens rotations) in the linear algebra backend to speed up the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant