Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8_build_config.json #26

Open
amourfou opened this issue Jun 2, 2022 · 2 comments
Open

v8_build_config.json #26

amourfou opened this issue Jun 2, 2022 · 2 comments

Comments

@amourfou
Copy link

amourfou commented Jun 2, 2022

Hi~
I have received your v8(10.0.139.9) NugetPackage for vs2022.
There is v8_build_config.json file in the package. I built v8 with it and made v8.dll, v8_libbase.dll, and so on.
But, When I compiled my MFC project with v8.dll made by me, link error took place. The error message is "error LNK2019: "class std::unique_ptr<class v8::Platform,struct std::default_delete > __cdecl v8::platform::NewDefaultPlatform(int,enum v8::platform::IdleTaskSupport,enum v8::platform::InProcessStackDumping,class std::unique_ptr<class v8::TracingController,struct std::default_delete >)" (?NewDefaultPlatform@platform@v8@@ya?AV?$unique_ptr@VPlatform@v8@@U?$default_delete@VPlatform@v8@@@std@@@std@@HW4IdleTaskSupport@12@W4InProcessStackDumping@12@V?$unique_ptr@VTracingController@v8@@U?$default_delete@VTracingController@v8@@@std@@@4@@z)""
By the way, your v8.dll is linked with my project normally. It would be greatly appreciated if you could tell me what environment you compiled into.

@pmed
Copy link
Owner

pmed commented Jun 12, 2022

These NuGet packages already have V8 prebuilt as .dll libraries. You don't need to build in manually. That v8_build_config.json file is just for information which build options were used to build the V8 packages.

To use the packages in your project you normally should install it with Project-> Manage NuGet Packages... menu item in Visual Studio IDE, search e.g. for v8-v142-x64 and install it.

@amourfou
Copy link
Author

Hi~. Thank you for your response. I already succeeded in building my project with your NuGet package. But I am in situation that v8 source code must be modify due to my project. So I have to build v8 project myself. I made args.gn file by referring to your "v8_build_config.json" file, but the link error as above occurred when my v8.dll is linked with my project. I think that NewDefaultPlatform is not exported in my build option(args.gn). Could you let me know your args.gn? Thank you for your interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants