From 96ef1845d6fb8d510bb865fa4d419a8b1c3525b5 Mon Sep 17 00:00:00 2001
From: michaeljguarino <mjg@plural.sh>
Date: Thu, 5 Oct 2023 15:50:02 -0400
Subject: [PATCH] Handle nil value for role repos (#1259)

---
 .tool-versions                                 | 2 +-
 CONTRIBUTING.md                                | 4 ++--
 apps/core/lib/core/services/rbac.ex            | 3 ++-
 apps/rtc/lib/rtc_web/channels/shell_channel.ex | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.tool-versions b/.tool-versions
index 4eb340687..d4b7364b9 100644
--- a/.tool-versions
+++ b/.tool-versions
@@ -1,2 +1,2 @@
-erlang 24.3.4.10
+erlang 24.3.4.13
 elixir 1.12.3
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 0dcfdf1ea..0d58ed39c 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -31,8 +31,8 @@ asdf can be finnicky when instlalling erlang with mac, in which case you can res
 
 ```sh
 brew install erlang@24
-cp -r /opt/homebrew/opt/erlang@24/lib/erlang ~/.asdf/installs/erlang/24.3.4.10
-asdf reshim erlang 24.3.4.10
+cp -r /opt/homebrew/opt/erlang@24/lib/erlang ~/.asdf/installs/erlang/24.3.4.13
+asdf reshim erlang 24.3.4.13
 ```
 
 <!-- >
diff --git a/apps/core/lib/core/services/rbac.ex b/apps/core/lib/core/services/rbac.ex
index cd2da662f..0ad4c6372 100644
--- a/apps/core/lib/core/services/rbac.ex
+++ b/apps/core/lib/core/services/rbac.ex
@@ -44,11 +44,12 @@ defmodule Core.Services.Rbac do
     do: Enum.filter(roles, & &1.account_id == id)
   defp maybe_filter(roles, _, _), do: roles
 
-  defp matches_repository?(%Role{repositories: repos}, repository) do
+  defp matches_repository?(%Role{repositories: [_ | _] = repos}, repository) do
     repos
     |> Enum.map(& "^#{String.replace(&1, "*", ".*")}$" |> Regex.compile!())
     |> Enum.any?(&Regex.match?(&1, repository))
   end
+  defp matches_repository?(_, _), do: false
 
   defp permits_action?(%Role{permissions: %Role.Permissions{} = perms}, action),
     do: Map.get(perms, action)
diff --git a/apps/rtc/lib/rtc_web/channels/shell_channel.ex b/apps/rtc/lib/rtc_web/channels/shell_channel.ex
index 63772b8fb..7e6749ff5 100644
--- a/apps/rtc/lib/rtc_web/channels/shell_channel.ex
+++ b/apps/rtc/lib/rtc_web/channels/shell_channel.ex
@@ -1,7 +1,7 @@
 defmodule RtcWeb.ShellChannel do
   use RtcWeb, :channel
   alias Core.Services.{Shell.Pods, Shell}
-  alias Core.Schema.{CloudShell, User}
+  alias Core.Schema.{CloudShell}
 
   require Logger