Fix error handling for query cast errors (#871)

pluralsh · Apr 22, 2024 · a5b4fc8 · a5b4fc8
1 parent ff0f0fd
commit a5b4fc8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/console/graphql/exceptions/protocol.ex b/lib/console/graphql/exceptions/protocol.ex
@@ -13,5 +13,9 @@ defimpl Console.GraphQl.Exception, for: Ecto.NoResultsError do
 end
 
 defimpl Console.GraphQl.Exception, for: Ecto.CastError do
-  def error(_), do: {400, "invalid input"}
+  def error(_), do: {400, "could not find resource"}
+end
+
+defimpl Console.GraphQl.Exception, for: Ecto.Query.CastError do
+  def error(_), do: {404, "could not find resource"}
 end
diff --git a/lib/console/graphql/middleware/safe_resolution.ex b/lib/console/graphql/middleware/safe_resolution.ex
@@ -29,9 +29,11 @@ defmodule Console.Middleware.SafeResolution do
     Resolution.call(resolution, resolver)
   rescue
     exception ->
-      {_, msg} = Console.GraphQl.Exception.error(exception)
-      error = Exception.format(:error, exception, __STACKTRACE__)
-      Logger.error(error)
+      {code, msg} = Console.GraphQl.Exception.error(exception)
+      if code >= 500 do
+        error = Exception.format(:error, exception, __STACKTRACE__)
+        Logger.error(error)
+      end
       Resolution.put_result(resolution, {:error, msg})
   end
 end