phpstan lvl 5

pluginsGLPI · Nov 13, 2023 · 26b6065 · 26b6065
1 parent bcbea88
commit 26b6065
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 23 deletions.
diff --git a/inc/config.class.php b/inc/config.class.php
@@ -48,14 +48,6 @@ public static function getTypeName($nb = 0)
         return __('General setup of useditemsexport', 'useditemsexport');
     }
 
-   /**
-    * Print the config form
-    *
-    * @param $ID        Integer : ID of the item
-    * @param $options   array
-    *
-    * @return void (display)
-   **/
     public function showForm($ID, $options = [])
     {
 
@@ -89,11 +81,13 @@ public function showForm($ID, $options = [])
         echo "</tr>";
 
         $this->showFormButtons($options);
+
+        return true;
     }
 
    /**
     * Show dropdown Orientation (Landscape / Portrait)
-    * @param value (current preselected value)
+    * @param string $value (current preselected value)
     * @return void (display dropdown)
     */
     public function dropdownOrientation($value)
@@ -109,7 +103,7 @@ public function dropdownOrientation($value)
 
    /**
     * Show dropdown Format (A4, A3, etc...)
-    * @param value (current preselected value)
+    * @param string $value (current preselected value)
     * @return void (display dropdown)
     */
     public function dropdownFormat($value)

diff --git a/inc/export.class.php b/inc/export.class.php
@@ -49,7 +49,7 @@ public static function getTypeName($nb = 0)
     public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
 
-        if ($item->getType() == 'User') {
+        if ($item instanceof User) {
             if ($_SESSION['glpishow_count_on_tabs']) {
                 return self::createTabEntry(self::getTypeName(), self::countForItem($item));
             }
@@ -63,7 +63,7 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
         /** @var array $CFG_GLPI */
         global $CFG_GLPI;
 
-        if ($item->getType() == 'User') {
+        if ($item instanceof User) {
             if (Session::haveRightsOr('plugin_useditemsexport_export', [READ, CREATE, PURGE])) {
                 $PluginUseditemsexportExport = new self();
                 $PluginUseditemsexportExport->showForUser($item);
@@ -212,7 +212,7 @@ public function showForUser($item, $options = [])
     *
     * @param $users_id user ID
     *
-    * @return array of exports
+    * @return boolean
    **/
     public static function generatePDF($users_id)
     {
@@ -389,7 +389,7 @@ public static function generatePDF($users_id)
 
    /**
     * Store Document into GLPi DB
-    * @param refnumber
+    * @param string $refnumber
     * @return integer id of Document
     */
     public static function createDocument($refnumber)
@@ -414,7 +414,6 @@ public static function createDocument($refnumber)
 
    /**
     * Get next num
-    * @param nothing
     * @return integer
     */
     public static function getNextNum()
@@ -433,13 +432,10 @@ public static function getNextNum()
             $nextNum++;
             return $nextNum;
         }
-
-        return false;
     }
 
    /**
     * Compute next refnumber
-    * @param nothing
     * @return string
     */
     public static function getNextRefnumber()
@@ -448,17 +444,17 @@ public static function getNextRefnumber()
         global $DB;
 
         if ($nextNum = self::getNextNum()) {
-            $nextRefnumber = str_pad($nextNum, 4, "0", STR_PAD_LEFT);
+            $nextRefnumber = str_pad((string)$nextNum, 4, "0", STR_PAD_LEFT);
             $date = new DateTime();
             return $nextRefnumber . '-' . $date->format('Y');
         } else {
-            return false;
+            return '';
         }
     }
 
    /**
     * Get all used items for user
-    * @param ID of user
+    * @param integer $ID ID of user
     * @return array
     */
     public static function getAllUsedItemsForUser($ID)

diff --git a/inc/profile.class.php b/inc/profile.class.php
@@ -44,7 +44,7 @@ class PluginUseditemsexportProfile extends CommonDBTM
     public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     {
 
-        if ($item->getType() == 'Profile' && $item->getField('interface') != 'helpdesk') {
+        if ($item instanceof Profile && $item->getField('interface') != 'helpdesk') {
             return PluginUseditemsexportExport::getTypeName();
         }
         return '';

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,7 @@
 parameters:
     parallel:
         maximumNumberOfProcesses: 2
-    level: 1
+    level: 5
     bootstrapFiles:
         - ../../inc/based_config.php
     paths: