From d9dec18546a92768d9c85c3ee11884e0a0505bf5 Mon Sep 17 00:00:00 2001
From: Jonathan Poole <jonfpoole@gmail.com>
Date: Wed, 8 Dec 2021 20:21:04 +0000
Subject: [PATCH] Fix readme and move config to a test profile (#3)

---
 .github/workflows/plugin.yaml | 4 +---
 .plzconfig                    | 5 ++---
 .plzconfig.test               | 2 ++
 README.md                     | 6 ++----
 4 files changed, 7 insertions(+), 10 deletions(-)
 create mode 100644 .plzconfig.test

diff --git a/.github/workflows/plugin.yaml b/.github/workflows/plugin.yaml
index 1cca657..7611b6d 100644
--- a/.github/workflows/plugin.yaml
+++ b/.github/workflows/plugin.yaml
@@ -7,9 +7,7 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v2
       - name: Run tests
-        run: ./pleasew test --log_file plz-out/log/test.log -e e2e
-      - name: Run e2e test
-        run: ./pleasew test --log_file plz-out/log/e2e.log -i e2e
+        run: ./pleasew test --profile test --log_file plz-out/log/test.log
       - name: Archive logs
         if: always()
         uses: actions/upload-artifact@v2
diff --git a/.plzconfig b/.plzconfig
index 6ddb004..b283b09 100644
--- a/.plzconfig
+++ b/.plzconfig
@@ -1,7 +1,6 @@
 ; TODO(jpoole): this plugin shouldn't contain the actually proto languages
 
-[Plugin "proto"]
-Definition = //build_defs/languages:js
+
 
 [Plugin "python"]
 ModuleDir = third_party.python
@@ -16,7 +15,7 @@ ExcludePythonRules = true
 name = proto
 
 [PluginConfig "definitions"]
-ConfigKey = Definition
+ConfigKey = LanguageDef
 Repeatable = true
 
 [PluginConfig "protoc_tool"]
diff --git a/.plzconfig.test b/.plzconfig.test
new file mode 100644
index 0000000..c05d651
--- /dev/null
+++ b/.plzconfig.test
@@ -0,0 +1,2 @@
+[Plugin "proto"]
+LanguageDef = //build_defs/languages:js
\ No newline at end of file
diff --git a/README.md b/README.md
index bda66ba..8ccbf6f 100644
--- a/README.md
+++ b/README.md
@@ -1,14 +1,12 @@
 # Proto rules
-Protobuff rules for the [Please](https://please.build) build system.
+Protobuf rules for the [Please](https://please.build) build system.
 
 # Basic usage 
 First add the base proto plugin to your project:
 ```python
 # BUILD
-# This adds the plugin to your project
-github_repo(
+plugin_repo(
     name = "proto",
-    repo = "please-build/proto-rules",
     revision = "<Some git tag, commit, or other reference>",
 )
 ```