Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong defines in VelocityBuffer.shader #13

Open
danielmaciel opened this issue Jan 21, 2017 · 1 comment
Open

Wrong defines in VelocityBuffer.shader #13

danielmaciel opened this issue Jan 21, 2017 · 1 comment

Comments

@danielmaciel
Copy link

danielmaciel commented Jan 21, 2017

Hi,

EDIT: On file VelocityBuffer.shader

While trying to understand the algorithm, I noticed on line 10 the multi_compile statement and the following defines: TILESIZE_10, TILESIZE_20, TILESIZE_40.

But when they are used they are spelled differently (line 72 and onwards): TILE_SIZE_10, TILE_SIZE_20, TILE_SIZE_40. Note the underscores between 'TILE' and 'SIZE'.

Does that mean you always use a tile size of 1 on those shaders? Is that what shipped with the game?

** BEGIN EDIT **

I ask this because on file VelocityBuffer.cs, line 37, neighborMaxSupport is initialized like this:

public NeighborMaxSupport neighborMaxSupport = NeighborMaxSupport.TileSize20;

So apparently it was supposed to be TILESIZE_20 by default?

** END EDIT **

** EDIT ** Apparently this pass is not even being used because of 'neighborMaxGen' being 'false', so maybe this issue is not important

Best regards,
Daniel

@Invertex
Copy link

It is reimplemented in my branch, but it doesn't seem to do much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants