Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/harden drush 9 alias site name and location #896

Open
Berdir opened this issue Jan 21, 2020 · 0 comments
Open

Improve/harden drush 9 alias site name and location #896

Berdir opened this issue Jan 21, 2020 · 0 comments

Comments

@Berdir
Copy link

Berdir commented Jan 21, 2020

We've discussed the drush 9 alias problem already a bit in slack, and I've reported consolidation/site-alias#38

Turns out that at least part of what I said was wrong, using an alias without location still works. What's completely broken however is site names that contain a ".", drush9 gets horribly confused over those, it still reports them with drush sa, but they don't work at all, neither with the location or without.

So maybe it would make sense to validate the proposed site name when generating aliases and not allowing to use it?

Second, currently drush 8 and 9 aliases are put in .drush/site-aliases. And even though site aliases without a "." work as @site.env, it's pretty confusing to not have them listed like that IMHO. I'm not quite sure what's going to happen with my issue and the location handling now, but I think it's fairly safe to assume that the special-handling of the sites folder will remain, so possibly drush9 aliases could be put in $HOME/.drush/sites or alternatively directly in $HOME/.drush (which at at least my config already supported, not sure if I set that up myself or if https://github.com/platformsh/platformsh-cli/blob/b61993a02acb63029e1a6bc7426d0cd3be01c5a6/src/Command/Local/LocalDrushAliasesCommand.php#L180 adds both locations.

Would be a bit awkward probably with the current legacy file location and moving it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant