Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Archival URI in resource state from cluster namespace configuration #55

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

caffalaughrey
Copy link
Contributor

Description

Fixes #54.

  • Setting URI values in state following create and update
  • Removing empty string as default value for URI attributes

TODOs

  • Generate the docs.
  • Run the relevant tests successfully.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Added history_archival_uri and visibility_archival_uri to state from namespace describe config following create/update
  • Removed default value of stringdefault.StaticString("") for these attributes in favour of implicit null

Migration Guide

In cases where state drift is already happening due to the original issue, terraform apply resulting in change action for the resource will resolve.

@ganievs ganievs merged commit dc0f0b3 into platacard:main Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archival URI's not reliably maintained in resource state
3 participants