up

platacard · Dec 13, 2023 · b66afeb · b66afeb
1 parent 97ee12e
commit b66afeb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 56 deletions.
diff --git a/docs/resources/namespace.md b/docs/resources/namespace.md
@@ -26,6 +26,7 @@ resource "temporal_namespace" "example" {
 ### Required
 
 - `name` (String) Namespace name
+- `owner_email` (String) Namespace Owner Email
 
 ### Optional
 
@@ -34,7 +35,6 @@ resource "temporal_namespace" "example" {
 - `history_archival_state` (String) History Archival State
 - `history_archival_uri` (String) History Archival URI
 - `is_global_namespace` (Boolean) Namespace is Global
-- `owner_email` (String) Namespace Owner Email
 - `retention` (Number) Workflow Execution retention
 - `visibility_archival_state` (String) Visibility Archival State
 - `visibility_archival_uri` (String) Visibility Archival URI

diff --git a/examples/provider-install-verification/main.tf.test b/examples/provider-install-verification/main.tf.test
diff --git a/internal/provider/namespace_resource.go b/internal/provider/namespace_resource.go
@@ -91,9 +91,7 @@ func (r *NamespaceResource) Schema(ctx context.Context, req resource.SchemaReque
 			},
 			"owner_email": schema.StringAttribute{
 				MarkdownDescription: "Namespace Owner Email",
-				Optional:            true,
-				Computed:            true,
-				Default:             stringdefault.StaticString(""),
+				Required:            true,
 			},
 			"retention": schema.Int64Attribute{
 				MarkdownDescription: "Workflow Execution retention",
@@ -300,7 +298,7 @@ func (r *NamespaceResource) Update(ctx context.Context, req resource.UpdateReque
 		PromoteNamespace: data.IsGlobalNamespace.ValueBool(),
 	}
 
-	_, err := client.UpdateNamespace(ctx, request)
+	ns, err := client.UpdateNamespace(ctx, request)
 	if err != nil {
 		if _, ok := err.(*serviceerror.NamespaceAlreadyExists); !ok {
 			resp.Diagnostics.AddError("Request error", "namespace registration failed: "+err.Error())
@@ -314,14 +312,6 @@ func (r *NamespaceResource) Update(ctx context.Context, req resource.UpdateReque
 	tflog.Info(ctx, fmt.Sprintf("The namespace: %s is successfully registered", data.Name))
 	tflog.Trace(ctx, "created a resource")
 
-	ns, err := client.DescribeNamespace(ctx, &workflowservice.DescribeNamespaceRequest{
-		Namespace: data.Name.ValueString(),
-	})
-	if err != nil {
-		resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Unable to read Namespace info, got error: %s", err))
-		return
-	}
-
 	data = NamespaceResourceModel{
 		Name:                    types.StringValue(ns.NamespaceInfo.GetName()),
 		Id:                      types.StringValue(ns.NamespaceInfo.GetId()),