-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAYOUT_LANDSCAPE() rotates the Lay_* directions too #376
Comments
@Potherca: I need a new name that I'm compatible with older layouts and therefore I defined "LAY_..." in uppercase like all other layout related calls (which are defined in Layout.md). |
Hmmm. 🤔
Would there be a large downside to using Alternatively, another word could be used, like "Positioning" which would give us (as an abbreviated form) Footnotes
|
I like I don't understand your Another alternative could be that we add an additional optional argument to the |
No technical issue. The "potential problem" is that users might not understand the distinction between Usually I am not a big fan of boolean parameters, but in this case it might be a cleaner solution than introducing another set of functions. |
The "new"
LAYOUT_LANDSCAPE()
function offers a significant advantage: it maintains the orientation ofRel_*
relationships. For example,Rel_Up(a, bUp, ...)
correctly positionsbUp
abovea
.In contrast, the "old"
LAYOUT_LEFT_RIGHT()
function rotatesRel_Up(a, bUp, ...)
, resulting inbUp
being positioned to the left ofa
.However, the
Lay_*
functions were not updated accordingly and still apply rotation. As a result,Lay_Up(a, bUp)
positionsbUp
to the left ofa
.To address this, new
LAY_*
functions need to be introduced to allow layouts without rotation.The fix (new LAY_* functions) could be following:
The text was updated successfully, but these errors were encountered: