Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message buffer rework #44

Closed
boreq opened this issue Sep 8, 2022 · 2 comments · Fixed by #70 or #118
Closed

Message buffer rework #44

boreq opened this issue Sep 8, 2022 · 2 comments · Fixed by #70 or #118
Assignees
Labels
tech Technical tasks unrelated to enhancements or bugs

Comments

@boreq
Copy link
Contributor

boreq commented Sep 8, 2022

Message buffer is far from perfect right now.

  • it should ensure that a failure to update one feed doesn't mean that other feeds can't be updated
  • if some messages are missing and therefore can't be appended to a feed it should keep messages for a specific amount of time as messages can arrive out of order and try to reorder them (needed for Decouple domain and application by using pubsub #45)
  • it should try to delay validating signatures on messages and just peek their sequence numbers in case we get the same message from multiple sources (probably should replace the mechanism which lets the replication code get the sequence number from the message buffer, this is not really reliable if messages arrive out of order)
@boreq boreq added the tech Technical tasks unrelated to enhancements or bugs label Sep 8, 2022
@boreq boreq moved this to Backlog in Verse: Nos Projects Sep 12, 2022
@boreq boreq self-assigned this Sep 26, 2022
@boreq boreq moved this from Backlog to In Progress in Verse: Nos Projects Sep 26, 2022
@boreq boreq moved this from In Progress to Review in Verse: Nos Projects Sep 27, 2022
@boreq boreq linked a pull request Sep 27, 2022 that will close this issue
@boreq boreq moved this from Review to Todo in Verse: Nos Projects Oct 17, 2022
@boreq
Copy link
Contributor Author

boreq commented Oct 17, 2022

This was partially done but let's keep this open as we need more fixes here.

@boreq boreq moved this from Todo to In Progress in Verse: Nos Projects Nov 23, 2022
@boreq boreq linked a pull request Nov 28, 2022 that will close this issue
@boreq
Copy link
Contributor Author

boreq commented Nov 28, 2022

Closing as this is one of those long-running issues that will never be closed. We need to create small tasks for further smaller fixes in the future.

@boreq boreq closed this as completed Nov 28, 2022
Repository owner moved this from In Progress to Done in Verse: Nos Projects Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech Technical tasks unrelated to enhancements or bugs
Projects
Archived in project
1 participant