Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All commands and queries should have constructors #40

Open
boreq opened this issue Sep 6, 2022 · 0 comments · May be fixed by #210
Open

All commands and queries should have constructors #40

boreq opened this issue Sep 6, 2022 · 0 comments · May be fixed by #210
Assignees
@boreq
Labels
tech Technical tasks unrelated to enhancements or bugs

Comments

@boreq
Copy link
Contributor

boreq commented Sep 6, 2022

Right now commands and queries don't have constructors which is some kind of a weird approach that we stuck with together with my old team even though we all agreed they should have them. I kept doing the same thing for no particular reason.

As a part of this task we should:

  • make sure that commands and queries have private fields
  • make sure that commands and queries have strong constructors
  • make sure that command and query handlers check for zero value of command/query
@boreq boreq self-assigned this Sep 6, 2022
@boreq boreq added the tech Technical tasks unrelated to enhancements or bugs label Sep 6, 2022
@boreq boreq moved this to Backlog in Verse: Nos Projects Sep 12, 2022
@danlatorre danlatorre moved this from Delivery Backlog to Design Validation Experiments in Verse: Nos Projects Dec 19, 2022
@danlatorre danlatorre moved this from Design Validation Experiments to Delivery Backlog in Verse: Nos Projects Dec 19, 2022
@boreq boreq linked a pull request Feb 16, 2023 that will close this issue
Add constructors to all commands and queries #210
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boreq boreq

Labels
tech Technical tasks unrelated to enhancements or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add constructors to all commands and queries planetary-social/scuttlego
1 participant
@boreq