Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CSP config in environment variables #47

Closed
1 task
chereseeriepa opened this issue Nov 14, 2022 · 2 comments
Closed
1 task

Allow CSP config in environment variables #47

chereseeriepa opened this issue Nov 14, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chereseeriepa
Copy link
Contributor

chereseeriepa commented Nov 14, 2022

See: planetary-social/go-ssb-room#3 (comment)

The ContentSecurityPolicy has the graphql url hardcoded, so this isnt going to work when the graphql url changes.

"default-src 'self'; img-src 'self' https://graphql.planetary.pub data: ; connect-src 'self' https://graphql.planetary.pub"
  • this should be passed in as an environment variables instead
@chereseeriepa chereseeriepa added this to the Rooms v2 milestone Nov 14, 2022
@chereseeriepa chereseeriepa assigned rabble and unassigned boreq Nov 15, 2022
@chereseeriepa
Copy link
Contributor Author

@rabble this is the task i was talking about, currently in the go-ssb-room vue branch. CSP config for the graphql server endpoint is hardcoded, so it just needs to be moved to an environment variable instead

@chereseeriepa
Copy link
Contributor Author

@rabble I ended up doing it, it was simple just followed what other environment variables had done

@chereseeriepa chereseeriepa moved this from Todo to Review in Verse: Nos Projects Nov 16, 2022
@chereseeriepa chereseeriepa moved this from Review to Done in Verse: Nos Projects Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants