Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router::path! allows literal instead of a string literal #38

Open
pksunkara opened this issue Apr 18, 2021 · 0 comments
Open

router::path! allows literal instead of a string literal #38

pksunkara opened this issue Apr 18, 2021 · 0 comments
Labels
C: router Context: Router library D1: trivial Difficulty: Trivial to implement for beginners E: rust External: Rust T: quality Type: Code quality improvment U5: maybe Urgency: Maybe W: external Waiting: External

Comments

@pksunkara
Copy link
Owner

While we do check the types during compilation and it results in an error, I still think this is something that would need to be fixed to improve correctness and quality of the code.
@pksunkara pksunkara added E: rust External: Rust C: router Context: Router library D1: trivial Difficulty: Trivial to implement for beginners U5: maybe Urgency: Maybe T: quality Type: Code quality improvment W: external Waiting: External labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: router Context: Router library D1: trivial Difficulty: Trivial to implement for beginners E: rust External: Rust T: quality Type: Code quality improvment U5: maybe Urgency: Maybe W: external Waiting: External
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pksunkara