Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should happen if I use /, # or ? in static part for Path? #30

Open
pksunkara opened this issue Feb 23, 2021 · 0 comments
Open

What should happen if I use /, # or ? in static part for Path? #30

pksunkara opened this issue Feb 23, 2021 · 0 comments
Labels
C: router Context: Router library D3: medium Difficulty: Medium to implement T: bug Type: Bug fix U5: maybe Urgency: Maybe W: design Waiting: Needs design

Comments

@pksunkara
Copy link
Owner

pksunkara commented Feb 23, 2021 •
edited
Loading

When doing the following:

Path::new().path("static")

We need to think about what happens when those special URI characters are given.

This would need work in the p! macro too.
@pksunkara pksunkara added D2: easy Difficulty: Easy to implement T: bug Type: Bug fix C: router Context: Router library U5: maybe Urgency: Maybe W: design Waiting: Needs design D3: medium Difficulty: Medium to implement and removed D2: easy Difficulty: Easy to implement labels Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: router Context: Router library D3: medium Difficulty: Medium to implement T: bug Type: Bug fix U5: maybe Urgency: Maybe W: design Waiting: Needs design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pksunkara