Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out the init and router parts in reign_plugin #16

Open
pksunkara opened this issue Nov 20, 2020 · 0 comments
Open

Separate out the init and router parts in reign_plugin #16

pksunkara opened this issue Nov 20, 2020 · 0 comments
Labels
C: plugin Context: Plugin library D3: medium Difficulty: Medium to implement E: rust External: Rust T: ergonomics Type: Ergonomic improvement U2: need to have Urgency: Need to have W: external Waiting: External

Comments

@pksunkara
Copy link
Owner

pksunkara commented Nov 20, 2020

This can be achievable by adding default router plugin trait if not defined for all init plugin trait implementations.

Needs rust trait specialization

For example, the redis plugin doesn't need the router part of the plugin, and thus does not need to bring the reign_router dep in reign_plugin.

@pksunkara pksunkara added C: plugin Context: Plugin library D3: medium Difficulty: Medium to implement E: rust External: Rust T: ergonomics Type: Ergonomic improvement U2: need to have Urgency: Need to have W: external Waiting: External labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: plugin Context: Plugin library D3: medium Difficulty: Medium to implement E: rust External: Rust T: ergonomics Type: Ergonomic improvement U2: need to have Urgency: Need to have W: external Waiting: External
Projects
None yet
Development

No branches or pull requests

1 participant