[OJS] tinymce error (downloadable font: OS/2: bad linegap: -32 ) with Firefox

[ajnyga]

While testing OJS3 I noticed that my co-workers Firefox 50 keeps on getting this error in console:
downloadable font: OS/2: bad linegap: -32 (font-family: "tinymce" style:normal weight:normal stretch:normal src index:1) source: http://mydomain.fi/lib/pkp/lib/vendor/tinymce/tinymce/skins/lightgray/fonts/tinymce.woff skin.min.css:1:30806

I use Firefox 50 as well, but for some reason I do not get that.

There are a lot of similar errors reported when I googled around. This seems to have at least some sort of solution: TryGhost/Casper#154

[asmecher]

@NateWr, any idea?

[ajnyga]

Hi @asmecher,

I am getting this in Firefox 50 / OSX. As I mentioned earlier, in FF50/Win7 I could not see this.

Someone here roundcube/roundcubemail#4788 says that:

The font issue is probably unrelated and fixed in git with update to TinyMCE 4.1.8.

And it seems that OJS3 is using 4.1.7.

Edit: ok, here is the actual issue from tinymce git:
tinymce/tinymce#2136

[NateWr]

Thanks for the detective work @ajnyga! @asmecher any concerns updating the bundle of TinyMCE? Should we hold that for a major update (3.1)?

[asmecher]

Go for it on the master branch; we can back-port to ojs-stable-3_0_1 if needed and once we're relatively sure it's stable.

[NateWr]

I updated to the latest version (v4.6.4), which is a big jump. I did some clicking around and didn't notice any issues. I also took the liberty of changing the main body text to white to match other input fields.

PRs (tests running):
#2589
pkp/tinymce#17
pkp/ojs#1422

[NateWr]

Tests passed. Not much code to review, but @bozana could you take a look at this to ensure it's working smoothly?

[bozana]

@NateWr, great, works well! All merged, I think.