-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement role check for mailables #10571
Comments
…il templates within a mailable
…s to email templates within a mailable
…s to email templates within a mailable
…il templates within a mailable
Thanks, @taslangraham. It's looking good. Lots going on here! Mostly a few minor requests, but I would like to take a look at the field components together. I think we can get away with using the existing We can take a look together on our next call, but feel free to have a look ahead of time. Since none of user groups will be changing dynamically on the frontend, we can do all this setup in PHP and just pass the options through the form setup functions. Let me know if you have any questions. |
@ewhanson Thanks for the review! I'll make the requested changes, and look into the usage of the |
…il templates within a mailable
…s to email templates within a mailable
…email templates within a mailable
@ewhanson I've made updates based on your review feedback and our discussion earlier today. |
As part of the work that needs to be done for #10403, we need to implement role checks for mailables and email templates:
Role Designation for Email Templates: Enable editors to assign specific user groups when creating or editing an email template. This feature should be restricted to mailables associated with the submission workflow.
Role Designation for mailables Allow mailables to be assigned to specific roles, ensuring that templates are accessible only to users with relevant roles.
Template-Specific Restrictions: Users should only access templates explicitly assigned to their group within each mailable. For example, if a mailable is accessible to both editors and authors, but a specific template is restricted to editors, then only editors should see that template, and authors should not have access.
PRs
ojs - pkp/ojs#4510
pkp-lib - https://github.com/pkp/pkp-lib/pull/10581/files
ui-library - pkp/ui-library#446
omp - pkp/omp#1768
ops - https://github.com/pkp/ops/pull/815/files
The text was updated successfully, but these errors were encountered: