Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConvertApacheAccessLogFile CLI tool #10321

Closed
bozana opened this issue Aug 15, 2024 · 2 comments
Closed

Fix ConvertApacheAccessLogFile CLI tool #10321

bozana opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Aug 15, 2024

In the issue #9911 the following bugs were encountered, that should be fixed for 3.4 as well:

  • the converted usage log files should contain the canonical URLs
  • there is a bug in requiring egrep to run the CLI tool
  • ensure that the last day form the Apache access log file is considered
  • the current Apache access log files (and their possible URLs) should be also considered -- earlier we were only considering access log files from installations < 3.4 that did not contain chapter URLs.

PRs:

@bozana bozana self-assigned this Aug 15, 2024
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Aug 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Statistics Aug 15, 2024
@bozana bozana added this to the 3.4.0-7 milestone Aug 15, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Aug 15, 2024
bozana added a commit to bozana/omp that referenced this issue Aug 15, 2024
@bozana bozana changed the title Ffix ConvertApacheAccessLogFile CLI tool Fix ConvertApacheAccessLogFile CLI tool Aug 15, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Aug 15, 2024
bozana added a commit to bozana/omp that referenced this issue Aug 15, 2024
bozana added a commit to bozana/ojs that referenced this issue Aug 15, 2024
bozana added a commit to bozana/ops that referenced this issue Aug 15, 2024
@bozana
Copy link
Collaborator Author

bozana commented Aug 15, 2024

@jonasraoni, would you maybe like to take a look at this PR -- it is actually the same as for the main branch except that here the URLs with locales are not considered.

bozana added a commit to bozana/pkp-lib that referenced this issue Aug 22, 2024
bozana added a commit to bozana/ojs that referenced this issue Aug 22, 2024
bozana added a commit to bozana/omp that referenced this issue Aug 22, 2024
bozana added a commit to bozana/ops that referenced this issue Aug 22, 2024
bozana added a commit that referenced this issue Aug 23, 2024
#10321 Fix ConvertApacheAccessLogFile CLI tool
bozana added a commit to pkp/ojs that referenced this issue Aug 23, 2024
bozana added a commit to pkp/omp that referenced this issue Aug 23, 2024
bozana added a commit to pkp/ops that referenced this issue Aug 23, 2024
pkp/pkp-lib#10321 submodule update ##bozana/10321##
@bozana
Copy link
Collaborator Author

bozana commented Aug 23, 2024

Because it was reviewed for the main branch in this issue #9911, and it is a function rarely used, and for the fix to go into the next release, I will merge it...

@bozana bozana closed this as completed Aug 23, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Statistics Aug 23, 2024
Hafsa-Naeem pushed a commit to Hafsa-Naeem/pkp-lib that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
Status: Done
Development

No branches or pull requests

1 participant