Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert controlled vocabulary classes to Eloquent models #10292

Open
asmecher opened this issue Aug 8, 2024 · 7 comments
Open

Convert controlled vocabulary classes to Eloquent models #10292

asmecher opened this issue Aug 8, 2024 · 7 comments
Assignees
@touhidurabir
Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@asmecher
Copy link
Member

asmecher commented Aug 8, 2024 •
edited by touhidurabir
Loading

There are several classes that use the old DAO storage model to handle controlled vocabularies and related code:

  • controlled_vocab_entries and controlled_vocab_entry_settings (these will require a trait for settings tables, which @Vitaliy-1 is working on)
  • controlled_vocabs
  • user_interests

In preparation for extensions to the controlled vocabulary toolset in support of vocabulary plugins that implement specific vocabs (e.g. LCSH etc), the storage model for these tables should be migrated to Eloquent.

PRs
pkp-lib --> #10324
ojs --> pkp/ojs#4403
omp --> pkp/omp#1722
ops --> pkp/ops#788
citationStyleLanguage --> pkp/citationStyleLanguage#127
jatsTemplate --> pkp/jatsTemplate#54
oaiJats --> pkp/oaiJats#51
reviewReport --> pkp/reviewReport#52
@asmecher asmecher added this to the 3.5.0 LTS milestone Aug 8, 2024
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
e9c27fc
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
9375230
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
852c673
This was referenced Aug 16, 2024
Open
Open
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 16, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
d1e3e38
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
85bf407
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
a9d82cd
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 16, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ae25aff
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
a581dc9
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
5db03d3
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
09dbd87
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 19, 2024
@touhidurabir
pkp#10292 typo fixed
12072a7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 19, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
2055e6d
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
5cefa04
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
20fefd2
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 Controlled Vocab DAO to Eloquent Model
dd868ac
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 WIP: Controlled Vocab DAO to Eloquent Model
8b5d705
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 typo fixed
15f9263
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 proper model import for native xml
4845517
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
ff4e8f7
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
80cd267
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
22f3d1c
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
a8b8438
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 added user_interests primary key migration
c40165b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 fixed user_interests primary key migration path
46d784e
touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Aug 20, 2024
@touhidurabir
pkp#10292 fixing unit tests
1463f2d
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Aug 20, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c517c8b
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 revert back context id direct addition to vocabs
80231b5
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
a4cd46f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
cd576c0
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
9e91c75
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 WIP: Controlled Vocab DAO to Eloquent Model
14ebb31
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c0ed29f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
341f10f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 removed user_interests table primary key migration …
594c009 
…as already exist
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Refactored user interest to model and repository
67f4fd2
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 removed extended vocab classes
21ad830
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 refactored entry dao to model class
e52e2b6
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
e657c5f
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
1f064f8
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 removed setting_type column
59d40f4
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
8797f20
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
caad4db
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 migration to handle context based query
ecab2a0
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 make context id required on controlled vocabs opera…
9f36bb8 
…tions
touhidurabir added a commit to touhidurabir/ojs that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 revert back context id direct addition to vocabs
8cce945
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
160ced7
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
c452dae
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 user interest vocab const added
9ba996a
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
855e5ea
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
60101be
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
e176037
touhidurabir added a commit to touhidurabir/omp that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 user interest vocab const added
2aeb598
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
f4f983a
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Controlled Vocab DAO to Eloquent Model
df7f504
touhidurabir added a commit to touhidurabir/ops that referenced this issue Nov 29, 2024
@touhidurabir
pkp/pkp-lib#10292 Submodule Update ##touhidurabir/i10292_main##
23612a9
@touhidurabir
Copy link
Member

@asmecher I have updated PRs, removed the context_id association with vocabs . All tests are passing for OJS, OMP and OPS except Scrutinizer (which does not seems like an issue at our end) . Please review the PRs at #10292 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@touhidurabir touhidurabir

Labels
Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
3 participants
@asmecher @touhidurabir @mreiko