Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap Page Error when browseBySection Plugin is Active #36

Closed
kswro opened this issue Oct 11, 2023 · 1 comment
Closed

Sitemap Page Error when browseBySection Plugin is Active #36

kswro opened this issue Oct 11, 2023 · 1 comment
Assignees
Milestone

Comments

@kswro
Copy link

kswro commented Oct 11, 2023

Describe the bug
Browse By Section plugin causes the sitemap page to be inaccessible (error 500) when activated. When deactivating this plugin, the sitemap page can be accessed again.

To Reproduce
Steps to reproduce the behavior:

  1. Fresh Install
  2. Download and activate the Browse By Section plugin
  3. Access the sitemap page (ex: https://your.site/journal/sitemap)
  4. HTTP Error 500

What application are you using?

  1. OJS 3.4.0.3
  2. Browse By Section 1.2.1.0
  3. PHP 8.2.11

Additional Information
restful_urls = On

Log

PHP Fatal error:  Uncaught Error: Non-static method PKP\core\PKPApplication::getRequest() cannot be called statically in /home/.../public_html/plugins/generic/browseBySection/BrowseBySectionPlugin.php:303
Stack trace:
#0 [internal function]: APP\plugins\generic\browseBySection\BrowseBySectionPlugin->addSitemapURLs()
#1 /home/.../public_html/lib/pkp/classes/plugins/Hook.php(139): call_user_func_array()
#2 /home/.../public_html/lib/pkp/classes/plugins/Hook.php(113): PKP\plugins\Hook::run()
#3 /home/.../public_html/pages/sitemap/SitemapHandler.php(78): PKP\plugins\Hook::call()
#4 /home/.../public_html/lib/pkp/pages/sitemap/PKPSitemapHandler.php(50): APP\pages\sitemap\SitemapHandler->_createContextSitemap()
#5 [internal function]: PKP\pages\sitemap\PKPSitemapHandler->index()
#6 /home/.../public_html/lib/pkp/classes/core/PKPRouter.php(334): call_user_func()
#7 /home/.../public_html/lib/pkp/classes/core/PKPPageRouter.php(277): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()
#8 /home/.../public_html/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPPageRouter->route()
#9 /home/.../public_html/lib/pkp/classes/core/PKPApplication.php(387): PKP\core\Dispatcher->dispatch()
#10 /home/.../public_html/index.php(21): PKP\core\PKPApplication->execute()
#11 {main}
  thrown in /home/.../public_html/plugins/generic/browseBySection/BrowseBySectionPlugin.php on line 303
@kaitlinnewson
Copy link
Member

Fixed and released for 3.3/3.4, closing.

@kaitlinnewson kaitlinnewson self-assigned this Dec 5, 2024
@kaitlinnewson kaitlinnewson added this to the 1.2.0.1 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants