Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests can fail due to .config/pkgdev/pkgdev.conf modifications #201

Open
anthonyryan1 opened this issue Nov 24, 2024 · 0 comments
Open

Tests can fail due to .config/pkgdev/pkgdev.conf modifications #201

anthonyryan1 opened this issue Nov 24, 2024 · 0 comments

Comments

@anthonyryan1
Copy link

anthonyryan1 commented Nov 24, 2024

I observed that if I run pytest within a fresh git clone of this repository, some tests failed.

I realized this is caused by the tests still using my .config/pkgdev/pkgdev.conf file while testing.

The following sample pkgdev.conf file demonstrates the problem:

[DEFAULT]
commit.signoff = true

Which leads to TestPkgdevCommitParseArgs::test_commit_signing && TestPkgdevCommitParseArgs::test_git_commit_args_passthrough failing.

Not urgent, because it's easily worked around by removing that argument from pkgdev.conf. But we've got outside environment leaking into tests and causing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant