Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should arguments other than 'command' be checked for definedness? #33

Open
jkeenan opened this issue Jan 26, 2020 · 0 comments
Open

Should arguments other than 'command' be checked for definedness? #33

jkeenan opened this issue Jan 26, 2020 · 0 comments
Labels
stalled Not enough information yet to resolve issue

Comments

@jkeenan
Copy link
Collaborator

jkeenan commented Jan 26, 2020

In RT 41149 in 2008, checks were added to ensure that no undefined value was passed as the "command" element in the list of arguments to publicly available methods. However, at that time, Paul Fenwick wrote:

"I'd also like it to contain checks for any undefined elements being passed to IPC::System::Simple ...."

That was not completed at that time. However, in order to assess the benefits of warning or dieing on undefined values, we'd first have to have some plausible test cases where passing an undefined value other than to a command would be a bad thing, either because it caused a crash or bad result or because it generated a badly formatted error message or warning.

Until we get such test cases, this issue is stalled.

@jkeenan jkeenan added the stalled Not enough information yet to resolve issue label Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Not enough information yet to resolve issue
Projects
None yet
Development

No branches or pull requests

1 participant