Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPC::System::Simple adds commas to command line breaking everything #10

Open
wilx opened this issue Feb 6, 2014 · 6 comments
Open

IPC::System::Simple adds commas to command line breaking everything #10

wilx opened this issue Feb 6, 2014 · 6 comments
Labels

Comments

@wilx
Copy link

wilx commented Feb 6, 2014

I am using autodie which uses IPC::System::Simple. IPC::System::Simple appears to be completely broken on Windows. It adds , (comma) after each command line argument. This is because it does this:

IPC::System::Simple::runx(C:/ActivePerl64/site/lib/IPC/System/Simple.pm:191):
191:            my $pid = _spawn_or_die($command, "$command @args");

The string interpolation seems to do that.

My version is 1.25, using ActivePerl.

@wilx
Copy link
Author

wilx commented Feb 6, 2014

See also #11

@wilx
Copy link
Author

wilx commented Feb 6, 2014

Argh, sorry for the noise but it still does not seem to be right. The backslash quoting is odd/wrong.

@wilx
Copy link
Author

wilx commented Feb 6, 2014

I think this time it is right.

@wilx
Copy link
Author

wilx commented Feb 6, 2014

Just for reference, these are the rules I have followed to construct this fix: http://msdn.microsoft.com/en-us/library/17w5ykft(v=vs.120).aspx

@pjf
Copy link
Owner

pjf commented Feb 6, 2014

You are awesome, thank you!

It's pretty late in Australia, but I'll see if I can drum up some testers and we'll get this into the next release. Thank you again! :)

~ Paul

@wilx
Copy link
Author

wilx commented Mar 7, 2014

Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants