Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.csv.parsers.splitLines(csv) does not work #26

Open
GoogleCodeExporter opened this issue Apr 12, 2015 · 4 comments
Open

$.csv.parsers.splitLines(csv) does not work #26

GoogleCodeExporter opened this issue Apr 12, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Returns:

Uncaught TypeError: Cannot read property 'separator' of undefined 
jquery.csv-0.71.min.js:27
$.csv.parsers.splitLines jquery.csv-0.71.min.js:27



When I add the optional configuration {separator: "," , delimiter: "\x22" } the 
console returns:

Uncaught TypeError: Cannot read property 'rowNum' of undefined 
jquery.csv-0.71.min.js:27
$.csv.parsers.splitLines jquery.csv-0.71.min.js:27

Original issue reported on code.google.com by [email protected] on 7 Apr 2013 at 6:09

@GoogleCodeExporter
Copy link
Author

Checked the source and it's a simple problem of an empty options.state object.

Line 278: if(!options.state.rowNum)

When I pass in an option like this it works:
var splitLines = $.csv.parsers.splitLines(t, {separator: ",", delimiter: 
"\x22", state: { } });




Original comment by [email protected] on 7 Apr 2013 at 6:20

@GoogleCodeExporter
Copy link
Author

I'll take a look at it.

I added more state tracking on the last update and probably just missed the 
default state object creation on the splitLines method.

Thank you for the feedback.

Original comment by [email protected] on 8 Apr 2013 at 4:25

@GoogleCodeExporter
Copy link
Author

If you want a quick and dirty fix. Just add a 'state' object literal with 
rowNum and colNum both initialized to 0.

To see what I mean, just take a look at some of the other functions. The proper 
fix would be to make splitLines so it inherits its state from the function 
arguments with defaults as a fallback.

Original comment by [email protected] on 23 Apr 2013 at 12:59

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 9 Dec 2013 at 11:32

  • Changed state: Accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant