Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a fill guide #147

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add a fill guide #147

wants to merge 7 commits into from
+407 −1

Conversation

GoodBoyDigital
Copy link
Member

Adds a fill guide! feedback welcome.

I will add some examples too. But keen to understand if this guide is all good first!

bigtimebuddy
bigtimebuddy approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. There are some places where you're using let and some const, would be great to be more uniform about that. Preference is probably const.

@GoodBoyDigital
Copy link
Member Author

GoodBoyDigital commented Dec 12, 2024 •
edited
Loading

Looks great. There are some places where you're using let and some const, would be great to be more uniform about that. Preference is probably const.

ah yes! updated to use consts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodBoyDigital @bigtimebuddy