You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, due to unitvec function there is no possibility to store 'list' vector - it has to be np.array /ndarray, otherwise None is returned.
Due to fact there is no imput check maybe it will be nice to edit unitvec function so it will change list object to np.array, e.g:
defunitvec(vec):
""" Scale a vector to unit length. The only exception is the zero vector, which is returned back unchanged. """ifisinstance(vec, list):
vec=numpy.array(vec)
....
BR, Marcin
The text was updated successfully, but these errors were encountered:
@mkoralew I think the whole framework expects vectors to be of type np.array / ndarray?
I never tried it with list vectors. Are you saying that this is the only place where this conversion would be needed in order to make list vectors work?
If you want to use list vectors and they are not supported by the framework feel free to add the support including tests in a pull request.
Hi, due to unitvec function there is no possibility to store 'list' vector - it has to be np.array /ndarray, otherwise None is returned.
Due to fact there is no imput check maybe it will be nice to edit unitvec function so it will change list object to np.array, e.g:
BR, Marcin
The text was updated successfully, but these errors were encountered: