From 8663e8b3d89fa44468a34667047f85a702714cc2 Mon Sep 17 00:00:00 2001
From: clavedeluna <danalitovsky+git@gmail.com>
Date: Thu, 9 Nov 2023 11:20:44 -0300
Subject: [PATCH] optimize django debug codemod

---
 src/core_codemods/django_debug_flag_on.py     | 32 +++++++++----------
 .../semgrep/django-debug-flag-on.yaml         | 10 ------
 2 files changed, 15 insertions(+), 27 deletions(-)
 delete mode 100644 src/core_codemods/semgrep/django-debug-flag-on.yaml

diff --git a/src/core_codemods/django_debug_flag_on.py b/src/core_codemods/django_debug_flag_on.py
index da38891f..38b23c40 100644
--- a/src/core_codemods/django_debug_flag_on.py
+++ b/src/core_codemods/django_debug_flag_on.py
@@ -9,18 +9,16 @@ class DjangoDebugFlagOn(SemgrepCodemod):
     DESCRIPTION = "Flip `Django` debug flag to off."
     SUMMARY = "Disable Django Debug Mode"
     REVIEW_GUIDANCE = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW
-    REFERENCES = (
-        [
-            {
-                "url": "https://owasp.org/www-project-top-ten/2017/A3_2017-Sensitive_Data_Exposure",
-                "description": "",
-            },
-            {
-                "url": "https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-DEBUG",
-                "description": "",
-            },
-        ],
-    )
+    REFERENCES = [
+        {
+            "url": "https://owasp.org/www-project-top-ten/2017/A3_2017-Sensitive_Data_Exposure",
+            "description": "",
+        },
+        {
+            "url": "https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-DEBUG",
+            "description": "",
+        },
+    ]
 
     @classmethod
     def rule(cls):
@@ -33,11 +31,11 @@ def rule(cls):
                - settings.py
         """
 
-    def leave_Assign(self, original_node, updated_node):
-        # checks if this module is a settings.py file from django's default directory structure
-        if is_django_settings_file(self.file_context.file_path):
-            return super().leave_Assign(original_node, updated_node)
-        return updated_node
+    def visit_Module(self, _: cst.Module) -> bool:
+        """
+        Only visit module with this codemod if it's a settings.py file.
+        """
+        return is_django_settings_file(self.file_context.file_path)
 
     def on_result_found(self, _, updated_node):
         return updated_node.with_changes(value=cst.Name("False"))
diff --git a/src/core_codemods/semgrep/django-debug-flag-on.yaml b/src/core_codemods/semgrep/django-debug-flag-on.yaml
deleted file mode 100644
index 630e9acc..00000000
--- a/src/core_codemods/semgrep/django-debug-flag-on.yaml
+++ /dev/null
@@ -1,10 +0,0 @@
-rules:
-  - id: django-debug-flag-on
-    message: Django's debug flag is on
-    severity: WARNING
-    languages:
-      - python
-    pattern: DEBUG = True
-    paths:
-      include:
-        - settings.py