From a95cd0e27f6287351d940733b9cbefb7dbc3da9b Mon Sep 17 00:00:00 2001 From: Lorenzo Bettini Date: Wed, 24 Aug 2022 17:02:47 +0200 Subject: [PATCH] 205: simple PitUiUpdate I seem to understand that no one is using the passed html so I removed that Task-Url: https://github.com/pitest/pitclipse/issues/205 --- .../ui/extension/point/PitUiUpdate.java | 18 ++---------------- .../ui/view/PitUiUpdatePublisher.java | 8 ++------ .../org/pitest/pitclipse/ui/view/PitView.java | 2 +- 3 files changed, 5 insertions(+), 23 deletions(-) diff --git a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/extension/point/PitUiUpdate.java b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/extension/point/PitUiUpdate.java index c4a8ebe1..ab701ec5 100644 --- a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/extension/point/PitUiUpdate.java +++ b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/extension/point/PitUiUpdate.java @@ -23,27 +23,13 @@ */ public class PitUiUpdate { - private final String html; - - private PitUiUpdate(String html) { - this.html = html; - } - - public String getHtml() { - return html; + private PitUiUpdate() { } public static final class Builder { - private String html; - - public Builder withHtml(String html) { - this.html = html; - return this; - } - public PitUiUpdate build() { - return new PitUiUpdate(html); + return new PitUiUpdate(); } } diff --git a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitUiUpdatePublisher.java b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitUiUpdatePublisher.java index f48daee4..7033545b 100644 --- a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitUiUpdatePublisher.java +++ b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitUiUpdatePublisher.java @@ -17,7 +17,6 @@ package org.pitest.pitclipse.ui.view; import org.eclipse.core.runtime.Platform; -import org.eclipse.swt.browser.Browser; import org.eclipse.swt.browser.ProgressEvent; import org.eclipse.swt.browser.ProgressListener; import org.pitest.pitclipse.core.extension.handler.ExtensionPointHandler; @@ -31,11 +30,9 @@ public class PitUiUpdatePublisher implements ProgressListener { private static final String EXTENSION_POINT_ID = "org.pitest.pitclipse.ui.results"; - private final Browser browser; private final ExtensionPointHandler handler; - public PitUiUpdatePublisher(Browser browser) { - this.browser = browser; + public PitUiUpdatePublisher() { this.handler = new ExtensionPointHandler<>(EXTENSION_POINT_ID); } @@ -44,8 +41,7 @@ public void changed(ProgressEvent event) { } public void completed(ProgressEvent event) { - PitUiUpdate update = new PitUiUpdate.Builder().withHtml( - browser.getText()).build(); + PitUiUpdate update = new PitUiUpdate.Builder().build(); handler.execute(Platform.getExtensionRegistry(), update); } diff --git a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitView.java b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitView.java index 1fdf64ac..3a11b095 100644 --- a/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitView.java +++ b/bundles/org.pitest.pitclipse.ui/src/org/pitest/pitclipse/ui/view/PitView.java @@ -50,7 +50,7 @@ public synchronized void createPartControl(Composite parent) { () -> { browser = new Browser(parent, SWT.NONE); resetBrowser(); - browser.addProgressListener(new PitUiUpdatePublisher(browser)); + browser.addProgressListener(new PitUiUpdatePublisher()); IActionBars actionBars = getViewSite().getActionBars(); IToolBarManager toolBar = actionBars.getToolBarManager(); // create back button