diff --git a/.github/workflows/tck-server.yml b/.github/workflows/tck-server.yml index 6ab2af307f..764f7b800d 100644 --- a/.github/workflows/tck-server.yml +++ b/.github/workflows/tck-server.yml @@ -27,7 +27,7 @@ jobs: run: mvn -B -DskipTests=true install - name: Run TCK run: mvn -amd -B -P external -pl external/tck/el verify - jakarta-servlet: + jakarta-pages: runs-on: ${{ matrix.os }} strategy: matrix: @@ -36,20 +36,16 @@ jobs: steps: - name: Checkout sources uses: actions/checkout@v4 - - name: Setup Java + - name: Set up Java ${{ matrix.java }} uses: actions/setup-java@v4 with: distribution: 'temurin' java-version: ${{ matrix.java }} - - name: Setup for TCK - run: mvn -B -DskipTests=true install -P${{ github.event.inputs.httpImplementation }} - if: ${{ github.event.inputs.httpImplementation }} - name: Setup for TCK run: mvn -B -DskipTests=true install - if: ${{ !github.event.inputs.httpImplementation }} - name: Run TCK - run: mvn -amd -B -P external -pl external/tck/servlet verify - jakarta-pages: + run: mvn -amd -B -P external -pl external/tck/wasp verify + servlet: runs-on: ${{ matrix.os }} strategy: matrix: @@ -63,7 +59,13 @@ jobs: with: distribution: 'temurin' java-version: ${{ matrix.java }} + - name: Setup for TCK + run: mvn -B -DskipTests=true install -P${{ github.event.inputs.httpImplementation }} + if: ${{ github.event.inputs.httpImplementation }} - name: Setup for TCK run: mvn -B -DskipTests=true install + if: ${{ !github.event.inputs.httpImplementation }} - name: Run TCK - run: mvn -amd -B -P external -pl external/tck/wasp verify + run: | + mvn -amd -B -P external -pl external/tck/server/servlet verify + cat external/tck/server/servlet/target/piranha/report/text/summary.txt >> $GITHUB_STEP_SUMMARY \ No newline at end of file diff --git a/external/tck/server/pom.xml b/external/tck/server/pom.xml new file mode 100644 index 0000000000..1dc9b50fca --- /dev/null +++ b/external/tck/server/pom.xml @@ -0,0 +1,26 @@ + + + + 4.0.0 + + cloud.piranha.external.tck + project + 24.9.0-SNAPSHOT + + cloud.piranha.external.tck.server + project + pom + Piranha - External - TCK - Server - Project + + + 6.0.1 + + + + servlet + + diff --git a/external/tck/server/servlet/pom.xml b/external/tck/server/servlet/pom.xml new file mode 100644 index 0000000000..38e6178476 --- /dev/null +++ b/external/tck/server/servlet/pom.xml @@ -0,0 +1,307 @@ + + + + 4.0.0 + + + cloud.piranha.external.tck.server + project + 24.9.0-SNAPSHOT + + + servlet-tck + pom + + Piranha Server - Jakarta Servlet TCK + + + + + cloud.piranha + bom + ${project.version} + import + pom + + + + + + ${project.build.directory}/ant + ${project.build.directory}/piranha + ${project.build.directory}/signature + ${project.build.directory}/tck + ${tck.home}/src/com/sun/ts/tests + + + + + + org.apache.maven.plugins + maven-antrun-plugin + + + validate + validate + + run + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +# exclude TCK tests per https://github.com/jakartaee/servlet/issues/488 +com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#invalidateHttpSessionxTest +com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxrfTest +com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxri1Test +com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxriTest +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchReturnTest4 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchReturnTest5 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest12 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest13 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest8 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest9 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest12 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest13 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest14 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest15 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest16 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest17 +# + + + +# exclude TCK test per https://github.com/jakartaee/servlet/issues/489 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest4 +# + + + +# exclude TCK test per https://github.com/jakartaee/servlet/issues/490 +com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest5 +# + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + pre-integration-test + pre-integration-test + + run + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + integration-test + integration-test + + run + + + + + + + + + + + + + + post-integration-test + post-integration-test + + run + + + + + + + + + + + + org.apache.maven.plugins + maven-dependency-plugin + + + copy + initialize + + copy + + + + + jakarta.servlet + jakarta.servlet-api + ${signature.home} + jakarta.servlet-api.jar + + + + + + unpack + initialize + + unpack + + + + + cloud.piranha.dist + piranha-dist-server + ${project.version} + zip + ${project.build.directory} + + + + + + + + + diff --git a/external/tck/servlet/src/test/etc/piranha-callers.xml b/external/tck/server/servlet/src/test/etc/piranha-callers.xml similarity index 100% rename from external/tck/servlet/src/test/etc/piranha-callers.xml rename to external/tck/server/servlet/src/test/etc/piranha-callers.xml diff --git a/external/tck/servlet/src/test/etc/ts-all.jtx b/external/tck/server/servlet/src/test/etc/ts-all.jtx similarity index 100% rename from external/tck/servlet/src/test/etc/ts-all.jtx rename to external/tck/server/servlet/src/test/etc/ts-all.jtx diff --git a/external/tck/servlet/src/test/etc/ts-exclude.jtx b/external/tck/server/servlet/src/test/etc/ts-exclude.jtx similarity index 100% rename from external/tck/servlet/src/test/etc/ts-exclude.jtx rename to external/tck/server/servlet/src/test/etc/ts-exclude.jtx diff --git a/external/tck/servlet/src/test/etc/ts-failed b/external/tck/server/servlet/src/test/etc/ts-failed similarity index 100% rename from external/tck/servlet/src/test/etc/ts-failed rename to external/tck/server/servlet/src/test/etc/ts-failed diff --git a/external/tck/servlet/src/test/etc/ts.jtx b/external/tck/server/servlet/src/test/etc/ts.jtx similarity index 100% rename from external/tck/servlet/src/test/etc/ts.jtx rename to external/tck/server/servlet/src/test/etc/ts.jtx diff --git a/external/tck/servlet/src/test/etc/user.properties b/external/tck/server/servlet/src/test/etc/user.properties similarity index 100% rename from external/tck/servlet/src/test/etc/user.properties rename to external/tck/server/servlet/src/test/etc/user.properties diff --git a/external/tck/servlet/src/test/etc/userrole.properties b/external/tck/server/servlet/src/test/etc/userrole.properties similarity index 100% rename from external/tck/servlet/src/test/etc/userrole.properties rename to external/tck/server/servlet/src/test/etc/userrole.properties diff --git a/external/tck/servlet/src/test/piranha/deploy.xml b/external/tck/server/servlet/src/test/piranha/deploy.xml similarity index 100% rename from external/tck/servlet/src/test/piranha/deploy.xml rename to external/tck/server/servlet/src/test/piranha/deploy.xml diff --git a/external/tck/servlet/pom.xml b/external/tck/servlet/pom.xml deleted file mode 100644 index 50a8b277fd..0000000000 --- a/external/tck/servlet/pom.xml +++ /dev/null @@ -1,704 +0,0 @@ - - - - 4.0.0 - - - cloud.piranha.external.tck - project - 24.10.0-SNAPSHOT - - - piranha-external-tck-servlet - pom - - Piranha - External - TCK - Servlet - - - - - cloud.piranha - bom - ${project.version} - import - pom - - - - - - ${project.build.directory}/ant - ${project.build.directory}/piranha - ${project.build.directory}/signature - ${project.build.directory}/tck - ${tck.home}/src/com/sun/ts/tests - - - - - unix - - - unix - - - - - - org.apache.maven.plugins - maven-antrun-plugin - - - validate - validate - - run - - - - Executing UNIX profile - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -# exclude TCK tests per https://github.com/jakartaee/servlet/issues/488 -com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#invalidateHttpSessionxTest -com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxrfTest -com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxri1Test -com/sun/ts/tests/servlet/api/jakarta_servlet_http/httpsessionx/URLClient.java#expireHttpSessionxriTest -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchReturnTest4 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchReturnTest5 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest12 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest13 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest8 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#negativeDispatchTest9 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest12 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest13 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest14 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest15 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest16 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#startAsyncAgainTest17 -# - - - -# exclude TCK test per https://github.com/jakartaee/servlet/issues/489 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest4 -# - - - -# exclude TCK test per https://github.com/jakartaee/servlet/issues/490 -com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/URLClient.java#dispatchAfterCommitTest5 -# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - pre-integration-test - pre-integration-test - - run - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - integration-test - integration-test - - run - - - - - - - - - - - - - - post-integration-test - post-integration-test - - run - - - - - - - - - - - - org.apache.maven.plugins - maven-dependency-plugin - - - copy - initialize - - copy - - - - - jakarta.servlet - jakarta.servlet-api - ${signature.home} - jakarta.servlet-api.jar - - - - - - unpack - initialize - - unpack - - - - - cloud.piranha.dist - piranha-dist-server - ${project.version} - zip - ${project.build.directory} - - - - - - - - - - - unix-isolated - - - - org.apache.maven.plugins - maven-antrun-plugin - - - validate - validate - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - run - - - - pre-integration-test - pre-integration-test - - run - - - - - - - - - - - - - - - - - - - - - - - Waiting till Piranha started - - - - - - - - - integration-test - integration-test - - run - - - - - - - - - - - - - - post-integration-test - post-integration-test - - - - - - - - run - - - - - - org.apache.maven.plugins - maven-dependency-plugin - - - copy - initialize - - copy - - - - - jakarta.servlet - jakarta.servlet-api - ${signature.home} - jakarta.servlet-api.jar - - - - - - unpack - initialize - - unpack - - - - - cloud.piranha.dist - piranha-dist-isolated - ${project.version} - zip - ${project.build.directory} - - - - - - - - - - - windows - - - windows - - - - - - org.apache.maven.plugins - maven-antrun-plugin - - - validate - validate - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - run - - - - pre-integration-test - pre-integration-test - - run - - - - - - - - - - - - - - - - - - integration-test - integration-test - - run - - - - - - - - - - - - - - post-integration-test - post-integration-test - - - - - - - run - - - - - - org.apache.maven.plugins - maven-dependency-plugin - - - copy - initialize - - copy - - - - - jakarta.servlet - jakarta.servlet-api - ${signature.home} - jakarta.servlet-api.jar - - - - - - unpack - initialize - - unpack - - - - - cloud.piranha.dist - piranha-dist-server - ${project.version} - zip - ${project.build.directory} - - - - - - - - - - -