Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINAnimatedImageView first frame rendering optimization #518

Open
hovox opened this issue Jul 10, 2019 · 0 comments
Open

PINAnimatedImageView first frame rendering optimization #518

hovox opened this issue Jul 10, 2019 · 0 comments

Comments

@hovox
Copy link
Contributor

hovox commented Jul 10, 2019

When we have tableview or collection view with gifs, scrolling up/down shows empty cell then loads an image. Changing coverImageCompleted method like this greatly improved experience. After this change we do not see empty cells

- (void)coverImageCompleted:(PINImage *)coverImage
{
    PINAssertMain();
   // BOOL setCoverImage = (_displayLink == nil) || _displayLink.paused;
    
//    if (setCoverImage) {
        [self setCoverImage:coverImage];
        [self.layer setNeedsDisplay];
//    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant