Support tiflash in list-append and rw-register test cases and add a tiflash specific case #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 21, 2021 12:11
lidezhu
changed the title
lidezhu
changed the title
added 2 commits
June 21, 2021 14:07
lilinghai
reviewed
Jun 23, 2021
| txnMode: txnMode, | ||
| replicaRead: replicaRead, | ||
| tiflashDataReplicas: tiflashDataReplicas, | ||
| it: elletxn.WrTxn(opt), |
There was a problem hiding this comment.
The function Create also needs "tiflashDataReplicas: r.tiflashDataReplicas,"
lilinghai
reviewed
Jun 23, 2021
| if err := loader.Flush(); err != nil { | ||
| log.Warn(err) | ||
| } | ||
| if _, err := db.Exec(fmt.Sprintf("DELETE FROM %s limit %d", tableName, deleteNum)); err != nil { |
There was a problem hiding this comment.
we should ensure the read engine is "TiKV" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: