Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iFrame or embed the settings page instead of leaving musicbox #72

Open
EHLOVader opened this issue Feb 27, 2015 · 2 comments
Open

iFrame or embed the settings page instead of leaving musicbox #72

EHLOVader opened this issue Feb 27, 2015 · 2 comments

Comments

@EHLOVader
Copy link

I may be disabling the settings and power buttons to prevent anyone from accidentally rebooting the server.

But would it be possible or helpful even to embed the settings frontend into the MusicBox interface so it would be easier to return using the sidebar?

@kingosticks
Copy link
Member

Yep I agree it would be a bit slicker. But it should be done in such a way
that mopidy-websettings still works and looks decent when used without
musicbox-Webclient. Although I don't know if many people make use of it as
a standalone extension, it's nice it's flexible like this.
On 27 Feb 2015 00:06, "Joseph Richardson" [email protected] wrote:

I may be disabling the settings and power buttons to prevent anyone from
accidentally rebooting the server.

But would it be possible or helpful even to embed the settings frontend
into the MusicBox interface so it would be easier to return using the
sidebar?


Reply to this email directly or view it on GitHub
#72.

@kingosticks kingosticks added this to the v1.2 - Bug cleanup milestone Mar 6, 2015
@kingosticks
Copy link
Member

I had a quick play with this a while ago and it needs a bit of fiddling, particularly with the different style sheets being used. Using the same/compatible styles would be the first step. I found just embedding the settings HTML into a div (like how the other sections work) to be easier than integrating an iframe. But both options are valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants