Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] request explicit input source #88

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

mattamon
Copy link
Contributor

Resolves #56

@mattamon mattamon added the Task label Nov 19, 2024
@mattamon mattamon added this to the 5.2.0 milestone Nov 19, 2024
@mattamon mattamon marked this pull request as draft November 19, 2024 12:56
@mattamon mattamon requested a review from kingjia90 November 19, 2024 13:23
@mattamon mattamon marked this pull request as ready for review November 19, 2024 13:23
@kingjia90 kingjia90 self-assigned this Nov 21, 2024
Copy link
Contributor

@kingjia90 kingjia90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, thank you!

.github/workflows/static-analysis.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mattamon mattamon requested a review from kingjia90 November 21, 2024 15:20
@mattamon mattamon merged commit 917681d into 5.x Nov 22, 2024
6 checks passed
@mattamon mattamon deleted the 56-request-input-explicit branch November 22, 2024 06:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Request::get with explicit input sources
2 participants