Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix object-brick structure #654

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[Bug] Fix object-brick structure #654

merged 1 commit into from
Jan 8, 2025

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Jan 8, 2025 •
edited
Loading

Changes in this pull request

Resolves #653

#Addtional Infos
Looks like this now:
image

@mattamon mattamon requested a review from lukmzig January 8, 2025 13:46
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lukmzig
lukmzig approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lukmzig lukmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattamon mattamon merged commit 8f1fd0d into 1.x Jan 8, 2025
12 checks passed
@mattamon mattamon deleted the 653-fix-object-brick-structure branch January 8, 2025 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukmzig lukmzig lukmzig approved these changes

Assignees
No one assigned
Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Object Editor] Structure of object bricks
2 participants
@mattamon @lukmzig