Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Use boolean arguments for mapped parameters directly #652

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Jan 8, 2025

Changes in this pull request

Resolves #649

Additional info

Seems like boolean parameters are now supported directly

@lukmzig lukmzig added the Task label Jan 8, 2025
@lukmzig lukmzig self-assigned this Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

@lukmzig lukmzig requested a review from mattamon January 8, 2025 07:11
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True or false that is the question.
Boolean on my young padawan. ⚡

@lukmzig lukmzig merged commit 8bb369a into 1.x Jan 8, 2025
12 checks passed
@lukmzig lukmzig deleted the 649-video-assets-image-thumbnail-aspectratiotrue-seems-to-not-work branch January 8, 2025 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Video Assets] Image thumbnail aspectRatio=true seems to not work
2 participants