Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Video Assets] Image thumbnail aspectRatio=true seems to not work #649

Closed
markus-moser opened this issue Jan 7, 2025 · 1 comment · Fixed by #652
Closed

[Video Assets] Image thumbnail aspectRatio=true seems to not work #649

markus-moser opened this issue Jan 7, 2025 · 1 comment · Fixed by #652
Assignees
@lukmzig
Labels
Task

Comments

@markus-moser
Copy link

markus-moser commented Jan 7, 2025 •
edited
Loading

The following example call:

/pimcore-studio/api/assets/353/video/stream/image-thumbnail?width=500&height=500&aspectRatio=true

should respect the aspect ratio of the image thumbnail of a video. Currently this seems to not work:

Image
@lukmzig lukmzig self-assigned this Jan 7, 2025
@lukmzig lukmzig added the Task label Jan 7, 2025
@lukmzig
Copy link
Contributor

lukmzig commented Jan 7, 2025

This is a general request topic. Until now it was not possible to map the request with boolean values directly.

This change symfony/symfony#59134 seems to allow it and therefore our request values need to be changed to bools.

See also: symfony/symfony#59353

@lukmzig lukmzig mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukmzig lukmzig

Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Task] Use boolean arguments for mapped parameters directly pimcore/studio-backend-bundle
2 participants
@markus-moser @lukmzig