Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid Config] Listing of the saved configurations should include the favorite information #590

Open
vin0401 opened this issue Nov 28, 2024 · 1 comment

Comments

@vin0401
Copy link

vin0401 commented Nov 28, 2024

In the UI we want to offer the user the possibility to (un-)favorite configurations based on the list of the available configurations:

Image

For this case it would be useful for us to include the favorite information in our listing endpoint:
/pimcore-studio/api/assets/grid/configurations/{folderId}

Also we are currently missing an option to unfavorite a configuration without sending an update for a specific configuration over the update endpoint: /pimcore-studio/api/assets/grid/configuration/update/{configurationId}

Either we should allow the update endpoint to accept partial updates, like a combination out of id and favorite.
Or rethink the currently available endpoint for setting a favorite: /pimcore-studio/api/assets/grid/configuration/set-as-favorite/{configurationId}/{folderId}

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant