Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Object Editor] Endpoints for editor #566

Open
17 of 19 tasks
markus-moser opened this issue Nov 22, 2024 · 8 comments
Open
17 of 19 tasks

[Data Object Editor] Endpoints for editor #566

markus-moser opened this issue Nov 22, 2024 · 8 comments
Assignees

Comments

@markus-moser
Copy link

markus-moser commented Nov 22, 2024

Top prio:

  • Regular GET endpoint for the data object data (based on field definition adapters and normalize() methods of the field defintions)

  • In the classic bundle /admin/object/get we also have additional relevant data which should be added to our new get endpoint (let's concentrate on the most important ones for now and see what we need in addition to that as soon as things become relevant):

    • allowInheritance
    • allowVariants
    • showVariants
    • hasPreview
  • A pendant for the following endpoints from classic bundle. Please take a look at the actions how they are implemented, they should offer the same possibilities and provide the same data:

    • /admin/class/fieldcollection-tree?_dc=1732263392203&allowedTypes=NewsCars%2CNewsLinks%2CNewsText&object_id=773&field_name=content&layoutId=0&forObjectEditor=1(we only need the forObjectEdit relevant infos without custom layouts for now)

    • /admin/class/objectbrick-tree?_dc=1732263612453&class_id=AP&object_id=408&field_name=saleInformation&layoutId=0&forObjectEditor=1 (we only need the forObjectEdit relevant infos without custom layouts for now)

    • /admin/quantity-value/unit-list.

    • /admin/settings/get-available-sites (we can skip the usesless "dao" attribute in the response)

    • /admin/quantity-value/convert

    • /admin/quantity-value/convert-all

    • pimcore_admin_dataobject_dataobject_getSelectOptions route

Additional topics:

  • Please analyze the following routes of the classic bundle - do our new pendants of the backend API offer the same possibilites or are relevant topics missing?

    • pimcore_admin_asset_getimagethumbnail
    • pimcore_admin_asset_download
    • pimcore_admin_asset_getvideothumbnail
  • For relation data types, there are several more routes involved. Didn't analyze them in detail right now, we need to find the right approach to solve those topics together:

    • pimcore_admin_dataobject_dataobject_add
    • pimcore_admin_dataobject_dataobjecthelper_loadobjectdata
    • pimcore_admin_dataobject_dataobject_get
    • pimcore_admin_element_lockelement
    • pimcore_admin_element_getnicepath
      • Needs Clarifications if this should be moved to core.. Also for Grid and export?
    • pimcore_admin_element_getsubtype
  • For the inline upload this route is used - not sure if our existing upload API already solves this?

    • pimcore_admin_asset_addassetcompatibility
@markus-moser
Copy link
Author

Also this related issues is relevant for the editor: #553

@martineiber
Copy link
Contributor

Part of pimcore/studio-ui-bundle#266

@lukmzig
Copy link
Contributor

lukmzig commented Nov 27, 2024

@markus-moser object data are now included in the get endpoint #578

@martineiber
Copy link
Contributor

@markus-moser Fieldcollection endpoint for the layout is also available #581

@lukmzig
Copy link
Contributor

lukmzig commented Nov 28, 2024

@markus-moser endpoints for the quantity values should be ready as well :)
#582

@markus-moser
Copy link
Author

@lukmzig I noticed a small problem with the quantity value endpoints, could you please check it? #598

@martineiber
Copy link
Contributor

@markus-moser Object Bricks are also available now #601

@martineiber
Copy link
Contributor

@markus-moser Endpoint for dynamic select options is now also available #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants