From a117ac97c1006db20647a4051669562864f08384 Mon Sep 17 00:00:00 2001
From: lukmzig <lukas.mzigot@pimcore.com>
Date: Fri, 29 Nov 2024 08:23:45 +0100
Subject: [PATCH] apply review feedback

---
 config/documents.yaml                         | 10 ++++-
 .../LayoutDefinitionService.php               | 10 ++---
 src/Document/Hydrator/SiteHydrator.php        | 37 +++++++++++++++++++
 .../Hydrator/SiteHydratorInterface.php        | 28 ++++++++++++++
 src/Document/Schema/Site.php                  |  3 ++
 src/Document/Service/SiteService.php          | 10 ++---
 6 files changed, 85 insertions(+), 13 deletions(-)
 create mode 100644 src/Document/Hydrator/SiteHydrator.php
 create mode 100644 src/Document/Hydrator/SiteHydratorInterface.php

diff --git a/config/documents.yaml b/config/documents.yaml
index 9e073012..f198214c 100644
--- a/config/documents.yaml
+++ b/config/documents.yaml
@@ -27,4 +27,12 @@ services:
   #
 
   Pimcore\Bundle\StudioBackendBundle\Document\Repository\SiteRepositoryInterface:
-    class: Pimcore\Bundle\StudioBackendBundle\Document\Repository\SiteRepository
\ No newline at end of file
+    class: Pimcore\Bundle\StudioBackendBundle\Document\Repository\SiteRepository
+
+
+  #
+  # Hydrators
+  #
+
+  Pimcore\Bundle\StudioBackendBundle\Document\Hydrator\SiteHydratorInterface:
+    class: Pimcore\Bundle\StudioBackendBundle\Document\Hydrator\SiteHydrator
\ No newline at end of file
diff --git a/src/Class/Service/FieldCollection/LayoutDefinitionService.php b/src/Class/Service/FieldCollection/LayoutDefinitionService.php
index 7aa5b9ad..be1907e4 100644
--- a/src/Class/Service/FieldCollection/LayoutDefinitionService.php
+++ b/src/Class/Service/FieldCollection/LayoutDefinitionService.php
@@ -21,7 +21,7 @@
 use Pimcore\Bundle\StaticResolverBundle\Models\DataObject\DataObjectResolverInterface;
 use Pimcore\Bundle\StaticResolverBundle\Models\DataObject\FieldCollection\DefinitionResolverInterface;
 use Pimcore\Bundle\StudioBackendBundle\Class\Event\FieldCollection\LayoutDefinitionEvent;
-use Pimcore\Bundle\StudioBackendBundle\Class\Hydrator\FieldCollection\LayoutDefinitionHydratorInterface;
+use Pimcore\Bundle\StudioBackendBundle\Class\Hydrator\FieldCollection\SiteHydratorInterface;
 use Pimcore\Bundle\StudioBackendBundle\Class\Schema\LayoutDefinition;
 use Pimcore\Bundle\StudioBackendBundle\Exception\Api\NotFoundException;
 use Pimcore\Model\DataObject;
@@ -34,11 +34,11 @@
 final class LayoutDefinitionService implements LayoutDefinitionServiceInterface
 {
     public function __construct(
-        private readonly DataObjectResolverInterface $dataObjectResolver,
+        private readonly DataObjectResolverInterface      $dataObjectResolver,
         private readonly ClassDefinitionResolverInterface $classDefinitionResolver,
-        private readonly DefinitionResolverInterface $definitionResolver,
-        private readonly LayoutDefinitionHydratorInterface $layoutDefinitionHydrator,
-        private readonly EventDispatcherInterface $eventDispatcher,
+        private readonly DefinitionResolverInterface      $definitionResolver,
+        private readonly SiteHydratorInterface            $layoutDefinitionHydrator,
+        private readonly EventDispatcherInterface         $eventDispatcher,
     ) {
     }
 
diff --git a/src/Document/Hydrator/SiteHydrator.php b/src/Document/Hydrator/SiteHydrator.php
new file mode 100644
index 00000000..577d1337
--- /dev/null
+++ b/src/Document/Hydrator/SiteHydrator.php
@@ -0,0 +1,37 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Pimcore
+ *
+ * This source file is available under two different licenses:
+ * - GNU General Public License version 3 (GPLv3)
+ * - Pimcore Commercial License (PCL)
+ * Full copyright and license information is available in
+ * LICENSE.md which is distributed with this source code.
+ *
+ *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
+ *  @license    http://www.pimcore.org/license     GPLv3 and PCL
+ */
+
+namespace Pimcore\Bundle\StudioBackendBundle\Document\Hydrator;
+
+use Pimcore\Bundle\StudioBackendBundle\Document\Schema\Site;
+use Pimcore\Model\Site as SiteModel;
+
+/**
+ * @internal
+ */
+final class SiteHydrator implements SiteHydratorInterface
+{
+    public function hydrate(SiteModel $siteModel): Site
+    {
+        return new Site(
+            $siteModel->getId(),
+            $siteModel->getDomains(),
+            $siteModel->getMainDomain(),
+            $siteModel->getRootId(),
+            $siteModel->getRootPath(),
+        );
+    }
+}
diff --git a/src/Document/Hydrator/SiteHydratorInterface.php b/src/Document/Hydrator/SiteHydratorInterface.php
new file mode 100644
index 00000000..5c456805
--- /dev/null
+++ b/src/Document/Hydrator/SiteHydratorInterface.php
@@ -0,0 +1,28 @@
+<?php
+declare(strict_types=1);
+
+/**
+ * Pimcore
+ *
+ * This source file is available under two different licenses:
+ * - GNU General Public License version 3 (GPLv3)
+ * - Pimcore Commercial License (PCL)
+ * Full copyright and license information is available in
+ * LICENSE.md which is distributed with this source code.
+ *
+ *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
+ *  @license    http://www.pimcore.org/license     GPLv3 and PCL
+ */
+
+namespace Pimcore\Bundle\StudioBackendBundle\Document\Hydrator;
+
+use Pimcore\Bundle\StudioBackendBundle\Document\Schema\Site;
+use Pimcore\Model\Site as SiteModel;
+
+/**
+ * @internal
+ */
+interface SiteHydratorInterface
+{
+    public function hydrate(SiteModel $siteModel): Site;
+}
diff --git a/src/Document/Schema/Site.php b/src/Document/Schema/Site.php
index fead9cd1..98927f0e 100644
--- a/src/Document/Schema/Site.php
+++ b/src/Document/Schema/Site.php
@@ -26,6 +26,9 @@
     schema: 'Site',
     title: 'Site',
     required: [
+        'id',
+        'domains',
+        'domain',
     ],
     type: 'object'
 )]
diff --git a/src/Document/Service/SiteService.php b/src/Document/Service/SiteService.php
index d740f276..a1e8349f 100644
--- a/src/Document/Service/SiteService.php
+++ b/src/Document/Service/SiteService.php
@@ -17,6 +17,7 @@
 namespace Pimcore\Bundle\StudioBackendBundle\Document\Service;
 
 use Pimcore\Bundle\StudioBackendBundle\Document\Event\PreResponse\SiteEvent;
+use Pimcore\Bundle\StudioBackendBundle\Document\Hydrator\SiteHydratorInterface;
 use Pimcore\Bundle\StudioBackendBundle\Document\MappedParameter\ExcludeMainSiteParameter;
 use Pimcore\Bundle\StudioBackendBundle\Document\Repository\SiteRepositoryInterface;
 use Pimcore\Bundle\StudioBackendBundle\Document\Schema\Site;
@@ -32,6 +33,7 @@
 
     public function __construct(
         private EventDispatcherInterface $eventDispatcher,
+        private SiteHydratorInterface $siteHydrator,
         private SiteRepositoryInterface $siteRepository,
     ) {
     }
@@ -48,13 +50,7 @@ public function getAvailableSites(ExcludeMainSiteParameter $parameter): array
 
         $siteList = $this->siteRepository->listSites();
         foreach ($siteList as $siteEntry) {
-            $site = new Site(
-                $siteEntry->getId(),
-                $siteEntry->getDomains(),
-                $siteEntry->getMainDomain(),
-                $siteEntry->getRootId(),
-                $siteEntry->getRootPath(),
-            );
+            $site = $this->siteHydrator->hydrate($siteEntry);
 
             $this->eventDispatcher->dispatch(new SiteEvent($site), SiteEvent::EVENT_NAME);
             $sites[] = $site;