[Ecommerce] Product discount not being reflected in the Order Object

[IgorBenko]

Bug Report

Before doing any further steps (pull request/workaround) I would like to understand if the following is expected behaviour, a missing feature or just plain false understanding of the feature on my side.

The feature I am describing would be needed for a proper communication with an ERP system.

Issue description

When applying a voucher adding a product discount, the product discount doesn't seem to be reflected in any way in the final Order object. The cart discount is on the other hand clearly reflected under Price Modifications.

The applied Pricing Rule is saved with an ID to the Order Item. This might not be enough as the pricing rule might change and afterwards there is no way to understand how the Product Price was discounted.

Expected behavior

The reason for the Product Discount and the value of a discount are clearly reflected in the Order Object.

Actual behavior

Only the discounted Product Price is being persisted with a Pricing Rule ID (in Order-Item), which might not be enough to properly understand the final Order.

Steps to reproduce

Create following pricing rules.

Then make two orders:

• with product-discount voucher
• with cart-discount voucher

I hope I am not missing something obvious here :) Feedback is highly appreciated! Thanks

[fashxp]

Hi,
this absolutely makes sense.

I see two possible ways to fix this:

• add two additional fields (originalPrice, originalNetPrice) to the order item and store there the not-discounted price
• add the price information to the pricing-rule field collection and store the discounts for every pricing rule there.

I'm not sure, if the second way will work though - first I'm not sure, if we have the necessary information available when order items are written, and second there might be pricing rules that have other actions that product discount...

[IgorBenko]

Hi Christian,

thanks a lot for your prompt reply! Yes your suggestions make sense. The first suggestion seems doable and doesn't exclude a later implementation of your second suggestion.

We will evaluate the options and try to implement an appropriate solution.

Thank you!

[fashxp]

A PR would be awesome :)